Watching First Post does not send push notifications

[angus (Angus McLeod)]

Steps to reproduce

1. Enable browser push notifications for User A.
2. Set User A’s notification level for Category A to “Watching First Post”.
3. Log in as User B (in incognito) and post in Category A (Post A)

Expected: User A would receive a browser push notification for Post A.
Actual: User A receives no browser push notification. Notifications (i.e. in the user menu) and email alerts work as expected.

Likely Cause

In the PostAlerter notify_first_post_watchers passes Notification.types[:watching_first_post] as the type to create_notification: discourse/app/services/post_alerter.rb at main · discourse/discourse · GitHub

create_notification restricts the creation of notification alerts to NOTIFIABLE_TYPES which does not include :watching_first_post: discourse/app/services/post_alerter.rb at main · discourse/discourse · GitHub

This may be intentional, however reading through this discussion, I suspect not?

[angus (Angus McLeod)]

Any update on this one? I’d be happy to make a PR that adds watching_first_post to NOTIFIABLE_TYPES.

[david (David Taylor)]

This sounds like an oversight to me - watching first post should be exactly like watching… except only for the first post .

I think we can take the likes from Jeff and Sam to mean this is definitely pr-welcome

[angus (Angus McLeod)]

Made a PR for this: add watching_first_post to NOTIFIABLE_TYPES by angusmcleod · Pull Request #6887 · discourse/discourse · GitHub

[codinghorror (Jeff Atwood)]

Sure @david can you review?

[david (David Taylor)]

Merged, thanks @angus