"We haven't seen you in a while" doesn't actually bring you to Top

AI-generated summary

A discussion about the Discourse platform not redirecting users to the “Top” page after receiving the message “We haven’t seen you in a while” began with mcwumbly sharing a screenshot of the issue. zogstrip mentioned that the issue was previously fixed, but mcwumbly provided steps to reproduce the issue.

codinghorror questioned whether the target site had the latest version with the fix, and zogstrip confirmed that it did. However, mcwumbly was able to reproduce the issue again on a different site.

codinghorror and later codinghorror requested that the issue be re-examined, as it had regressed multiple times. zogstrip eventually announced that the issue had been fixed by david, who added tests to prevent the regression from happening again.

I just logged into another Discourse and it seems like it wanted to put me on /top, but I’m on Latest instead:

The URL in the browser says:

https://talk.commonmark.org/latest

And the topics all just look like the latest ones:

Version header from site shows:

Discourse 1.9.0.beta13 - https://github.com/discourse/discourse version cbdfc85466e049c53c01a759f5824d6431187a50
1 Mi Piace

Hmm, I did fix that a couple of weeks ago.

https://github.com/discourse/discourse/commit/e2124355459efbadc8cae374a5c3bb2a48111e07

Not sure if any of this is helpful @zogstrip, but here are the steps I remember taking before I grabbed that screenshot:

I got a digest email, and clicked on one of the links in there. Then I logged in, using Google auth. Then I was in the state shown above in the screenshot.

1 Mi Piace

Is the target site on a new enough version to have that fix?

Yes, commonmark’s forum had the fix at the time of the report…

3 Mi Piace

Can you repro this now?

Took me a while to remember a forum that I might not have visited in long enough, but just repro’d on https://discuss.kotlinlang.org/ which is on commit 7163bf9323618728a548aaaf133a93581db541f6 (3 days ago):

3 Mi Piace

@zogstrip this needs another look. It has also regressed multiple times now..

1 Mi Piace

Sorry for the delay, @mcwumbly, but it should now be fixed thanks to @david’s work :ok_hand:

https://github.com/discourse/discourse/commit/75488257c51eb9ed17f48134fb4e729fcce1cf6b

4 Mi Piace

I think (but haven’t checked) that this regressed when user-selectable home pages were added.

I’ve now added some tests so hopefully it won’t happen again. The redirection is tested for /, /latest and /categories.

5 Mi Piace

This topic was automatically closed after 5 days. New replies are no longer allowed.