Hey Discourse Team, This marks the 1-year-and-1-month anniversary of the Rails 5 release, it looks like 5.1.3 will be out soon (second release candidate lands today). Wondering if there have been any thoughts on upgrading Discourse to Rails 5.x anytime soon? Why or why not?

I think our main problem is that Active Record gets slower in each release? Not sure, but we worry much more about “keeping up with the Joneses” for Ember (client side JS) releases than Rails on the server side, which is quite mature.

[image] gdpelican: Wondering if there have been any thoughts on upgrading Discourse to Rails 5.x anytime soon? Why or why not? It is on my list to get us to the latest Rails but it isn’t our priority at the moment because none of the new features are useful for us. Right now, we’re working w…

I think upgrading to Rails 5 would be a good idea since the Action Cable could be useful especially for getting notifications…

We already use a much better library to handle all the notifications/updates :wink: https://github.com/samsaffron/message_bus

I am in for a long long ride… undefined method `xhr' for #<RSpec::ExampleGroups::AdminDashboardController::WhileLoggedInAsAnAdmin::Index::VersionCheckingIsDisabled:0x00564a2c54c820>

Ok I have tests green going for the main code base in https://github.com/discourse/discourse/pull/5122 When I thought I was done, I realized I’ll have to go through all our plugins as well otherwise :crying_cat_face: Will grind through those next week!

Rails 5.1 is now deployed on meta. I’m seeing performance regressed on the topics and categories page ATM so we can’t roll it out immediately to everyone. Another notable change is that Activerecord’s pluck is notably slower which I’ve submit a PR for in https://github.com/rails/rails/pull/30524 N…

[image] tgxworld: I’m seeing performance regressed on the topics and categories page Can you please specify how much, in percent?

4.2.9 Your Results: (note for timings- percentile is first, duration is second in millisecs) --- categories_admin: 50: 18 75: 18 90: 19 99: 27 home_admin: 50: 23 75: 23 90: 24 99: 29 topic_admin: 50: 18 75: 18 90: 19 99: 25 categories: 50: 43 75: 43 90: 48 99: 50 home…

When should Discourse upgrade to Rails 5?

Dev

sam (Sam Saffron) Août 11, 2017, 3:30 6

This has kind of changed because of Automatic encoding of parsed URL params - #26 by elijah , if the upgrade is not to painful and there is no perf regression we should go ahead.

Sujet		Réponses	Vues
Preparing for Discourse's upgrade to Ember 5 Announcements	53	7936	Avril 8, 2024
Upgrading Discourse to Rails 6 Development dev-news	17	4051	Janvier 7, 2020
Fail to upgrade discourse Support	4	1981	Décembre 3, 2016
Discourse Version 1.3 Announcements release-notes	1	20904	Mai 25, 2015
Discourse 2.5.0.beta3 Release Notes Announcements release-notes	1	4660	Avril 22, 2020

When should Discourse upgrade to Rails 5?

Sujets connexes