为什么即使禁用了安全上传，也要运行 UpdatePostUploadsSecureStatus？

saulshanabrook · 2023 年2 月 18 日 16:45

感谢您在支持不同 S3 后端方面所做的工作！我正在使用 minio，它运行得很棒……

我遇到的唯一小问题是 UpdatePostUploadsSecureStatus 作业失败，因为 Minio 不支持 ACL：

github.com/minio/minio

Support Object ACLs

opened 02:26PM - 06 Sep 19 UTC

closed 03:58AM - 07 Sep 19 UTC

rfornea

community out of scope triage

I've read through a few github issues and the minio docs, and it seems you don't… support setting object ACLs (nor intend to). You claim to be an S3 compatible server, but if you aren't supporting this feature, that's not really true IMO. Regardless of whether or not AWS recommends using ACLs, they nevertheless still support them and it is a good enough solution for plenty of people's usage. Not supporting object ACLs prevents Minio from being a drop-in replacement for S3. Someone who wanted to switch to Minio would have to start adding prefixes to everything which could break their existing naming scheme for objects. This is a problem if they wanted to be able to support objects stored in S3 and in Minio, and if they already had pre-existing data in S3 which used Object ACLs. This is the situation I personally am in. I really think you should reconsider this.

有没有办法禁用此作业的运行？

Falco · 2023 年2 月 18 日 16:51

您是否已启用 SiteSetting.secure_uploads？

saulshanabrook · 2023 年2 月 19 日 13:08

还没有。

编辑：我确实导入了一些包含嵌入式图片的电子邮件。我正在阅读电子邮件中的安全上传文档，这是在说所有来自电子邮件的上传都将是“安全的”吗？

Falco · 2023 年2 月 19 日 13:35

为什么即使在禁用该设置的情况下，我们也要为每个帖子上的每次上传安排此作业@martin？

martin · 2023 年2 月 19 日 23:38

好问题——这在两个地方被调用。PostCreator:

github.com/discourse/discourse

lib/post_creator.rb

3c57db5c6


      
          def update_uploads_secure_status
            @post.update_uploads_secure_status(source: "post creator") if SiteSetting.secure_uploads?
          end

以及 PostRevisor:

github.com/discourse/discourse

lib/post_revisor.rb

3c57db5c6


      
          # This must be done before post_process_post, because that uses
          # post upload security status to cook URLs.
          @post.update_uploads_secure_status(source: "post revisor")

不过正如你所见，我忽略了在后者中进行 SiteSetting.secure_uploads? 检查……我将提交一个 PR 来修复此问题，并将检查移至 post.update_uploads_secure_status。

编辑：PR 在这里，希望今天能合并 FIX: Do not enqueue UpdatePostUploadsSecureStatus unnecessarily by martin-brennan · Pull Request #20366 · discourse/discourse · GitHub

话题		回复	浏览量
Minio: A header you provided implies S3 functionality that is not implemented Support	20	9975	2021 年4 月 5 日
Can not edit topics with picture with S3 backend Bug	11	1113	2021 年7 月 12 日
Secure Uploads Announcements secure-uploads	46	16686	2025 年7 月 24 日
Upload objects to private S3 is not working Support s3	5	2536	2022 年6 月 14 日
Image upload error: The bucket does not allow ACL's Support s3	5	1713	2022 年6 月 10 日

为什么即使禁用了安全上传，也要运行 UpdatePostUploadsSecureStatus？

相关话题