Why vbulletin 4 importer exclude the firstpost?

enigmaty · November 21, 2016, 2:25pm

Why the importer in vbulletin exclude the firstpost from the total_count?

https://github.com/discourse/discourse/blob/master/script/import_scripts/vbulletin.rb#L433

zogstrip · November 21, 2016, 3:03pm

Most likely because the first post is used to create the topic.

enigmaty · November 21, 2016, 3:14pm

But then if I have ten topic/thread with attachment just in the first post, the total_count will be zero, even though I have ten attachments. right?

zogstrip · November 21, 2016, 3:19pm

Hmm, I didn’t look closely enough. Looks like you’re right

PRs are welcome

enigmaty · November 21, 2016, 3:26pm

Ok.

While we at it, this line cause errors:

github.com

discourse/discourse/blob/main/script/import_scripts/vbulletin.rb#L247


      
          ensure
            begin
              file.close
            rescue StandardError
              nil
            end
            begin
              file.unlind
            rescue StandardError
              nil
            end
          end
          
          def import_profile_background(old_user, imported_user)
            query = mysql_query <<-SQL
                SELECT filedata, filename
                  FROM #{TABLE_PREFIX}customprofilepic
                 WHERE userid = #{old_user["userid"]}
              ORDER BY dateline DESC
                 LIMIT 1
            SQL

I had to modified it just like the vb5 importer:

github.com

discourse/discourse/blob/main/script/import_scripts/vbulletin5.rb#L272


      
              FROM #{DB_PREFIX}node
              WHERE (unpublishdate = 0 OR unpublishdate IS NULL)
              AND (approved = 1 AND showapproved = 1)
              AND parentid IN (
              SELECT nodeid FROM #{DB_PREFIX}node WHERE contenttypeid=#{@channel_typeid} ) AND contenttypeid=#{@text_typeid};",
            ).first[
              "cnt"
            ]
          
          batches(BATCH_SIZE) do |offset|
            topics = mysql_query <<-SQL
              SELECT t.nodeid AS threadid, t.title, t.parentid AS forumid,t.open,t.userid AS postuserid,t.publishdate AS dateline,
                  nv.count views, 1 AS visible, t.sticky,
                  CONVERT(CAST(rawtext AS BINARY)USING utf8) AS raw
              FROM #{DB_PREFIX}node t
              LEFT JOIN #{DB_PREFIX}nodeview nv ON nv.nodeid=t.nodeid
              LEFT JOIN #{DB_PREFIX}text txt ON txt.nodeid=t.nodeid
              WHERE t.parentid in ( select nodeid from #{DB_PREFIX}node where contenttypeid=#{@channel_typeid} )
                AND t.contenttypeid = #{@text_typeid}
                AND (t.unpublishdate = 0 OR t.unpublishdate IS NULL)
                AND t.approved = 1 AND t.showapproved = 1

zogstrip · November 21, 2016, 4:22pm

What was the error? Did it try creating an already existing index?

enigmaty · November 21, 2016, 4:25pm

Yes I did. I get the error after the second run.

ref:
https://meta.discourse.org/t/vbulletin-importer-fails/26120

zogstrip · November 21, 2016, 4:26pm

Probably want to handle that better rather than just catching the exception

Topic		Replies	Views
Vbulletin4 import - Permalink issue Installation	7	1156	July 15, 2022
Issue with import script Dev	1	440	March 30, 2018
How to avoid uploading attachments multiple times in a migration Dev	2	753	September 25, 2017
vBulletin 5 import : how to import private messages? Migration vbulletin5	2	902	October 9, 2020
First post result link in search within topic causing entire topic to re-render Bug	3	1100	June 30, 2015

Why vbulletin 4 importer exclude the firstpost?

Related topics