Why vbulletin 4 importer exclude the firstpost?

enigmaty · 2016 年11 月 21 日 14:25

Why the importer in vbulletin exclude the firstpost from the total_count?

script/import_scripts/vbulletin.rb

main


      
                  rescue StandardError
                    nil
                  end
                next if raw.blank?
                next unless topic = topic_lookup_from_imported_post_id("thread-#{post["threadid"]}")
                p = {
                  id: post["postid"],
                  user_id: user_id_from_imported_user_id(post["userid"]) || Discourse::SYSTEM_USER_ID,
                  topic_id: topic[:topic_id],
                  raw: raw,
                  created_at: parse_timestamp(post["dateline"]),
                  hidden: post["visible"].to_i != 1,
                }
                if parent = topic_lookup_from_imported_post_id(post["parentid"])
                  p[:reply_to_post_number] = parent[:post_number]
                end
                p
              end
            end
          end

zogstrip · 2016 年11 月 21 日 15:03

Most likely because the first post is used to create the topic.

enigmaty · 2016 年11 月 21 日 15:14

But then if I have ten topic/thread with attachment just in the first post, the total_count will be zero, even though I have ten attachments. right?

zogstrip · 2016 年11 月 21 日 15:19

Hmm, I didn’t look closely enough. Looks like you’re right

PRs are welcome

enigmaty · 2016 年11 月 21 日 15:26

Ok.

While we at it, this line cause errors:

github.com/discourse/discourse

script/import_scripts/vbulletin.rb

main


      
          ensure
            begin
              file.close
            rescue StandardError
              nil
            end
            begin
              file.unlind
            rescue StandardError
              nil
            end
          end
          
          def import_profile_background(old_user, imported_user)
            query = mysql_query <<-SQL
                SELECT filedata, filename
                  FROM #{TABLE_PREFIX}customprofilepic
                 WHERE userid = #{old_user["userid"]}
              ORDER BY dateline DESC
                 LIMIT 1
            SQL

I had to modified it just like the vb5 importer:

github.com/discourse/discourse

script/import_scripts/vbulletin5.rb

main


      
              FROM #{DB_PREFIX}node
              WHERE (unpublishdate = 0 OR unpublishdate IS NULL)
              AND (approved = 1 AND showapproved = 1)
              AND parentid IN (
              SELECT nodeid FROM #{DB_PREFIX}node WHERE contenttypeid=#{@channel_typeid} ) AND contenttypeid=#{@text_typeid};",
            ).first[
              "cnt"
            ]
          
          batches(BATCH_SIZE) do |offset|
            topics = mysql_query <<-SQL
              SELECT t.nodeid AS threadid, t.title, t.parentid AS forumid,t.open,t.userid AS postuserid,t.publishdate AS dateline,
                  nv.count views, 1 AS visible, t.sticky,
                  CONVERT(CAST(rawtext AS BINARY)USING utf8) AS raw
              FROM #{DB_PREFIX}node t
              LEFT JOIN #{DB_PREFIX}nodeview nv ON nv.nodeid=t.nodeid
              LEFT JOIN #{DB_PREFIX}text txt ON txt.nodeid=t.nodeid
              WHERE t.parentid in ( select nodeid from #{DB_PREFIX}node where contenttypeid=#{@channel_typeid} )
                AND t.contenttypeid = #{@text_typeid}
                AND (t.unpublishdate = 0 OR t.unpublishdate IS NULL)
                AND t.approved = 1 AND t.showapproved = 1

zogstrip · 2016 年11 月 21 日 16:22

What was the error? Did it try creating an already existing index?

enigmaty · 2016 年11 月 21 日 16:25

Yes I did. I get the error after the second run.

ref:
https://meta.discourse.org/t/vbulletin-importer-fails/26120

zogstrip · 2016 年11 月 21 日 16:26

Probably want to handle that better rather than just catching the exception

话题		回复	浏览量
Issue with import script Dev	1	447	2018 年3 月 30 日
vBulletin import fails on import_topics Migration vbulletin	2	1152	2024 年6 月 8 日
Migrate a vBulletin 4 forum to Discourse Sysadmins how-to	183	30151	2025 年11 月 9 日
Mybb import skips importing posts Support	7	1302	2024 年6 月 8 日
Large Drupal forum migration, importer errors and limitations Migration drupal	28	2629	2023 年8 月 10 日

Why vbulletin 4 importer exclude the firstpost?

相关话题