Wizard mixes up must_approve_users and invite_only

RGJ · 4 فبراير 2020، 12:22م

The wizard offers a choice that sets invite_only or must_approve_users:

However…the second option sets invite_only, the third option sets must_approve_users

The texts seems to be mixed up in the translations file:

config/locales/server.en.yml

main


      
            text_body_template: |
              Somebody asked to reset your password on [%{site_name}](%{base_url}).
          
              If it was not you, you can safely ignore this email.
          
              Click the following link to choose a new password:
              %{base_url}/u/password-reset/%{email_token}
          
          email_login:

codinghorror · 4 فبراير 2020، 3:40م

Is this a new regression @eviltrout?

eviltrout · 4 فبراير 2020، 4:10م

This is nuts, but it looks like the text descriptions have been incorrect the entire time this feature existed!

Initial commit:

Here’s a fix:

الموضوع		الردود	مرات العرض
Staff-generated invites bypass the must_approve_users requirement Feature invites	29	2529	10 يونيو 2022
Allow users invited by staff to skip approval Feature invites	21	2157	12 أبريل 2023
Unrelated bug at the invitation confirmation dialog Support	3	915	22 مايو 2015
Trusted users cannot invite when must approve users admin setting enabled Support	10	936	17 يونيو 2021
Invite redemption allowed user to access forum BEFORE approval Bug approval , invites	7	3191	15 يناير 2022

Wizard mixes up must_approve_users and invite_only

الموضوعات ذات الصلة