Wizard mixes up must_approve_users and invite_only

The wizard offers a choice that sets invite_only or must_approve_users:

image

However…the second option sets invite_only, the third option sets must_approve_users

The texts seems to be mixed up in the translations file:

https://github.com/discourse/discourse/blob/master/config/locales/server.en.yml#L4500-L4508

8 Likes

Is this a new regression @eviltrout?

2 Likes

This is nuts, but it looks like the text descriptions have been incorrect the entire time this feature existed!

Initial commit:

https://github.com/discourse/discourse/commit/a63ef4cfc85

Here’s a fix:

https://github.com/discourse/discourse/commit/71312d90860b573467204f9e42dc0821aa8fc7cd

12 Likes