Wizard mixes up must_approve_users and invite_only

RGJ · February 4, 2020, 12:22pm

The wizard offers a choice that sets invite_only or must_approve_users:

However…the second option sets invite_only, the third option sets must_approve_users

The texts seems to be mixed up in the translations file:

config/locales/server.en.yml

main


      
              %{context}
          
              %{respond_instructions}
          
          user_mentioned_pm:
            title: "User Mentioned PM"
            subject_template: "[%{email_prefix}] [PM] %{topic_title}"
            subject_template_improved: "%{email_prefix}: %{topic_title}"
            text_body_template: |

codinghorror · February 4, 2020, 3:40pm

Is this a new regression @eviltrout?

eviltrout · February 4, 2020, 4:10pm

This is nuts, but it looks like the text descriptions have been incorrect the entire time this feature existed!

Initial commit:

Here’s a fix:

https://github.com/discourse/discourse/commit/71312d90860b573467204f9e42dc0821aa8fc7cd

Topic		Replies	Views
Staff-generated invites bypass the must_approve_users requirement Feature invites	28	2768	June 3, 2022
Allow users invited by staff to skip approval Feature invites	21	2329	April 12, 2023
Unrelated bug at the invitation confirmation dialog Support	2	932	May 22, 2015
Trusted users cannot invite when must approve users admin setting enabled Support	8	993	June 2, 2021
Invite redemption allowed user to access forum BEFORE approval Bug approval , invites	6	3228	January 13, 2022

Wizard mixes up must_approve_users and invite_only

Related topics