Uncategorized showing up on mobile

nbianca · April 21, 2021, 7:13pm

On desktop we show categories and topics separately, but on mobile we show categories with topics, combined. Keeping that in mind, it is this line that causes the bug:

github.com/discourse/discourse

app/models/category_list.rb

main


      
                DismissedTopicUser.lookup_for(@guardian.current_user, @all_topics)
              @dismissed_topic_users_lookup.include?(topic.id)
            else
              false
            end
          end
          
          def find_categories
            query = Category.includes(CategoryList.included_associations).secured(@guardian)
          
            if SiteSetting.content_localization_enabled
              locale = I18n.locale.to_s
              query =
                query.joins(
                  ActiveRecord::Base.sanitize_sql_array(
                    [
                      "LEFT JOIN category_localizations cl ON cl.category_id = categories.id AND cl.locale = ?",
                      locale,
                    ],
                  ),
                )

c.displayable_topics.blank? is always true on desktop because we load topics separately so displayable_topics is always blank. On mobile, it is true only if there are really no topics in that category.

We have two solutions here:

show uncategorized if there is at least a topic, no matter the value of ‘allow uncategorized topics’ setting
hide uncategorized even if there is a topic, if ‘allow uncategorized topics’ is false

The second solution is easier to implement because it means we simply remove the second part of the condition.

Topic		Replies	Views
Disabled Uncategorized category is shown in mobile browsers when unlogged Support	7	1181	July 9, 2018
Allow_uncategorized_topics doesn't work on mobile Support	4	575	June 14, 2019
Disabled Uncategorized shows in category dropdowns Bug	9	627	July 10, 2026
Uncategorized shows up in Categories menu and results in 404 Bug	13	2472	July 21, 2022
Non-staff users are able to access uncategorized even when disabled Bug	13	1880	July 23, 2019

Uncategorized showing up on mobile

Related topics