This was intentionally done when the feature was developed, the idea was following Firefox’s bookmark modal as an example… logic is:
- Click on new bookmark, click outside the modal, modal is closed and bookmark is created
- Click on new bookmark, click cancel, no bookmark is made
- Click on existing bookmark, a new “Remove bookmark” button shows up, you can use that to remove it.
This isn’t to say we shouldn’t change it if it’s confusing, but it’s technically not a bug. I’m going to move this to Contribute > UX. The difference between full-page modal (Discourse) and fly-out menu (Firefox) might be significant to warrant changing the behavior?