User Fields - weird signup behavior

ted · September 17, 2024, 2:34am

@ecki Sorry. I missed the fact that you’re on stable. I have opened a PR to back port this fix.

github.com/discourse/discourse

FIX: Fix incorrect check for required custom fields (#28541)

discourse:stable ← discourse:fix/required-fields-check-stable

opened 02:21AM - 17 Sep 24 UTC

Drenmi

+5 -2

### What is this change? Back port of #28541 to stable. This check was che…cking the wrong scope, causing problems in certain edge conditions, for example: 1. Admin adds an "on signup" field that isn't editable after signup. 2. Admin adds a "for all users" field. 3. User goes and fills up the "for all users" field from 2. 4. User is now stuck on the required fields page without any fields showing. With this change, we only consider "for all users" fields when asking if required custom fields are filled in.

Topic		Replies	Views
User Field Requirement (2) Bug user-custom-fields , fixed	8	104	August 29, 2024
Site setting to hide custom user fields from signup page Feature user-custom-fields	13	1755	February 28, 2023
Custom User fields not saving Bug	19	2164	October 5, 2017
Saving edits on user preferences page with required custom fields is unclear UX	8	1567	June 12, 2017
When an existing staged user Joins my site, filled in user custom fields data isn't saved Bug	13	988	June 28, 2023

User Fields - weird signup behavior

Related Topics