Rebuild issue: [Cannot set dual-stack in combination with a custom endpoint.]

[pfaffman (Jay Pfaffman)]

@martin

I merged a fix for this

Thanks for the quick fix! I’m back in business.

@Falco

See prior art

Thanks for the lucid explanation, Rafael!

@martin

these S3 clones always slip my mind.

That’s because there’s a lot of stuff to keep in mind! And the spec tests, I think, would require those annoying stub_requests which I know I hate writing.

@martin

I think the fix here can just to be never use dualstack if DISCOURSE_S3_ENDPOINT has been set since they are incompatible

FWIW, that sounds right to me. And you could probably write tests for that that didnt’ require stubs for stub_requests.