I can't save edit on site texts

Osama · April 11, 2025, 2:24am

Hey @songs, thanks for reporting the bug, it will be fixed once this PR is merged:

github.com/discourse/discourse

FIX: Refresh disabled state when switching between site texts

main ← fix/refresh-disabled-state-when-navigating-between-site-texts

opened 02:23AM - 11 Apr 25 UTC

OsamaSayegh

+15 -1

Repro steps: 1. Go to `/admin/customize/site_texts` 2. Click edit on any tra…nslation 3. Go back by clicking on "Back to search" 4. Click edit on another translation 5. Change the text field in any way Expected results: The disabled state on the "Save changes" button is removed and you're able to click it Actual results: The "Save changes" button remains disabled This happens because the computed property for the button's disabled state doesn't get re-evaluated when navigating between translation strings because it doesn't include on the `siteText` property in its dependent properties, so changing the site text doesn't invalidate the old value for the disabled state and it always stays the same. Meta topic: https://meta.discourse.org/t/i-cant-save-edit-on-site-texts/360990?u=osama

Topic		Replies	Views
Some settings aren't saving Support unsupported-install	11	955	July 27, 2023
Upload avatar failed, save changes disabled Bug	12	1250	March 14, 2023
Changing policy texts Support	5	22	March 12, 2025
Unable to save wiki update Support wiki-posts	7	866	February 27, 2024
Clicking "Keep Editing" button doesn't do anything Bug	7	548	April 22, 2023

I can't save edit on site texts

Related topics