Currently running Discourse 3.5.0.beta5-dev ( eff31e0d42 ). Would anyone know if the API response from the /admin/users/list/all.json endpoint has changed in the last week or so? :thinking: Specifically: GET /admin/users/list/all.json?email=email@example.com :thinking: I think this endpoint used …

Hi, yes sorry this shouldn’t have been merged, it was my mistake. But the good news is that I already reverted it 8 hours ago: DEV: revert admin users list change (#32723) · discourse/discourse@7558e2c · GitHub

No amount of searching through the 73x commits I updated with yesterday found this DEV: replace selenium driver with playwright breaking change. Thanks for the link @RGJ

[изображение] Richie: searching through the 73x commits My approach: load /admin/users/list/all.json?email=email@example.com check the x-discourse-route header look up the corresponding file (app/controllers/admin/users_controller.rb) look up the corresponding method (index) press “Blame” s…

Nooooo way… :scream: Well, that’s what I learnt today! Thanks @RGJ :clap:t2::star_struck:

I managed to find that commit somehow, but couldn’t (and still don’t) see where it changed the data structure (I was on my phone, making things a bit more difficult).

I’m guessing this was the breaking change in the API response :confused: In /app/assets/javascripts/admin/addon/controllers/admin-users-list-show.js [Screenshot 2025-05-11 at 15.36.17]

[изображение] pfaffman: where it changed the data structure It’s the line root: :users that was added.

We’ve now recovered from the impact of this change. Perhaps going a bit off topic here but is there a way I can track these types of updates so I can notify myself when an API response changes from “X”, after being “Y” for so many years? :thinking: Some kind of scripted local unit tests that I cou…

You could have a staging environment. You might also create a github action for your code that starts discourse and runs a test against the latest discourse each day.

[изображение] pfaffman: runs a test against the latest discourse each day Ah-ha! Perfect, that’d work, thanks :grin:

I think a plugin that called the endpoint and rendered it could be an easy way to test. And then change the default github action to run daily instead of only on push.

Изменения в структуре ответа API /admin/users/list/all.json?

Разработка

RGJ (Richard - Communiteq) 11.Май.2025 15:12:51 9

It’s the line root: :users that was added.

1 лайк

Тема		Ответов	Просм.
Cases when admin/users.json?email=foobar or admin/users/list/all.json?email=foobar return empty array Development rest-api , user-api	6	205	29.05.2025
Issues with the /get-users ending point Development rest-api	4	106	16.07.2024
How do I get a list of all users from the API? Development rest-api	18	11121	24.12.2021
Creating users through RESTFUL Users API - Users.json got wiped Development rest-api	4	1713	28.02.2019
Group API, empty response Development rest-api	7	877	08.06.2024

Изменения в структуре ответа API /admin/users/list/all.json?

Связанные темы