Toggling Visibility within a Topic connector

Development

AI-generated summary

The discussion is about toggling visibility within a Topic connector in Discourse. merefield initially proposed a PR to access the toggleVisibility action, but after david reviewed the implementation, he suggested using this.args.model.toggleStatus("visible") instead, which merefield found to be a more straightforward solution. The original name toggleVisibility was considered for renaming, but david and merefield agreed to keep it as-is to maintain consistency across Discourse.

1

I would like to access the Topic Controller’s toggleVisibility action within a component via a connector.

I see there is a precedent for this.

Would the following PR be accepted?:

to

      <span>
        <PluginOutlet
          @name="topic-above-post-stream"
          @connectorTagName="div"
          @outletArgs={{lazyHash
            model=@controller.model
            editFirstPost=@controller.editFirstPost
            toggleVisibility=@controller.toggleVisibility
          }}
        />
      </span>

If so, I’ll raise

Thanks!

2

Seems reasonable to me.

Although without looking, I’m not sure what toggleVisibility does. Should we give it a more descriptive name? :sweat_smile:

3

great!

well it’s the current naming convention for this action across Discourse

It’s the name used for listing and unlisting a topic.

4

Ah ok, better keep the name as-is then, rather than having to rename it everywhere :ok_hand:

5

Yeah, that was my thought :sweat_smile:

I’ll raise! :rocket:

6

Just looking at the implementation:

You already have access to the model in the connector, so does it make sense to just do this.args.model.toggleStatus("visible") from your connector instead?

7

wow, thanks, that’s awesome!

It definitely makes a lot less sense. I didn’t realise that existed, I’ll give that a go!