Error when I try to remove or change a reaction

Contribute Bug
,

AI-generated summary

User Moin reported an issue where they couldn’t remove or change a reaction on a specific post, encountering a 500 error. sam suspected it might be related to widgets and suggested checking the meta logs. Moin mentioned they couldn’t reproduce the issue on another post. sam confirmed it was an interaction with ActivityPub. angus suggested the issue might be due to the reactions plugin having different data scenarios for reactions. pmusaraj identified the problem as the activity_pub_object not existing during an undo activity and provided a fix. Moin asked if the issue was similar to a previous one involving the multilanguage plugin. pmusaraj was unsure but couldn’t reproduce the error when editing a title.

1

I cannot remove my :heart: reaction or choose a different reaction on AI helper does not always use user's locale - #6 by sam

image
image728×285 13.3 KB

2 Likes
2

Oh may be related to removal of widgets @saquetim

Thanks for reporting

3

So far, I have not been able to reproduce this on another post.

4

Since its a 500 something is going to be in the meta log which will help us

1 Like
7

The new tag reminded me of 500 error when adding a Language Tag (Multilingual Plugin) to a user's post - #5 by Moin where I had a similar problem when I edited the title

2 Likes
9

Turns out this is an interaction with ActivityPub:


plugins/discourse-activity-pub/app/models/concerns/discourse_activity_pub/a_p/model_callbacks.rb:96:in `performing_activity_object'
plugins/discourse-activity-pub/app/models/concerns/discourse_activity_pub/a_p/model_callbacks.rb:19:in `perform_activity_pub_activity'
plugins/discourse-activity-pub/plugin.rb:458:in `block (2 levels) in activate!'
lib/plugin/instance.rb:614:in `block in on'
lib/discourse_event.rb:12:in `block in trigger'
/usr/local/lib/ruby/3.3.0/set.rb:501:in `each_key'
/usr/local/lib/ruby/3.3.0/set.rb:501:in `each'
lib/discourse_event.rb:12:in `trigger'
lib/post_action_destroyer.rb:65:in `perform'
plugins/discourse-reactions/app/services/discourse_reactions/reaction_manager.rb:103:in `remove_shadow_like'
plugins/discourse-reactions/app/services/discourse_reactions/reaction_manager.rb:45:in `toggle_like'
plugins/discourse-reactions/app/services/discourse_reactions/reaction_manager.rb:34:in `block in toggle!'

@pmusaraj is going to have a look cc @angus

10

Thanks guys. @pmusaraj what is the actual exception? activity_pub_object doesn’t exist? I have a suspicion that the nub of the issue is the reactions plugin has three different data scenarios for reactions.

This may be the scenario where there’s no PostAction, or it’s created in an unconventional way, hence no AP object where one is expected. If so, AP will need to guard against that.

3 Likes
11

Sorry for my late reply here @angus. Yes, the issue was that the activity_pub_object didn’t exist during an undo activity.

I added a very simple fix in DEV: Fix test failures and an incompatibility with reactions by pmusaraj · Pull Request #234 · discourse/discourse-activity-pub · GitHub , I suspect eventually we’ll want something more robust here. But it should solve the current issue.

1 Like
12

Is it similar here? Is there an attempt to share the new title even though the topic has never been shared?

1 Like
13

This topic was automatically closed after 3 days. New replies are no longer allowed.

14

Possibly, not sure. I just edited that topic’s title twice and didn’t see an error.