I segnalibri esistono ancora per argomenti a cui non hai più accesso

zogstrip · 24 Dicembre 2025, 10:52am

Ottimo lavoro @JammyDodger

Questo sarà risolto da

github.com/discourse/discourse

FIX: filter bookmark count by access permissions

main ← fix-bookmark-count

opened 10:52AM - 24 Dec 25 UTC

ZogStriP

+320 -290

Previously, `UserSummary#bookmark_count` used a simple `Bookmark.where(user:).co…unt` which included bookmarks for content the user could no longer access (e.g., topics moved to private categories, deleted posts, or PMs they were removed from). This caused a mismatch where users saw "4 bookmarks" in their profile stats but an empty bookmark page. Added `BookmarkQuery#count_all` that reuses the same access-filtered UNION query as `list_all`, ensuring the count reflects only accessible bookmarks. Also refactored `BookmarkQuery` for clarity: - Extracted `build_list_queries` to share query building between `count_all` and `list_all` - Extracted helper methods in `unread_notifications`: `fetch_reminder_notifications`, `load_deleted_bookmarkables`, `can_see_notification_bookmark?` - Removed verbose comments and debug SQL formatting Ref - https://meta.discourse.org/t/391822

Argomento		Risposte	Visualizzazioni
Bookmark issue when access to topic is lost (PMs) Bug	6	1107	Marzo 11, 2017
Disappearing bookmarks and expected behavior of /bookmarks Bug bookmarks	24	1897	Novembre 11, 2023
Bookmarks are not removed even if the topic/post is moved to a PM/private category Bug bookmarks	2	360	Aprile 8, 2024
Moderators still able to access other users bookmarks Bug	2	2581	Aprile 4, 2016
Reporting few issues with bookmarks Bug	3	746	Aprile 29, 2020

I segnalibri esistono ancora per argomenti a cui non hai più accesso

Argomenti correlati