Recently, I added support for Urdu language , which, like Arabic, Hebrew, and Persian, is an RTL (right-to-left) language. To make the software aware of it I added ur locale in rtl_locales method of the RTL model class. app/models/rtl.rb 49fc54aac def rtl_locale…

[صورة] simon: I think the RTL class is used in UserNotifications for adding the rtl class to emails. Does this change anything? After all user’s locale or site’s default locale is determined in order to know if it belongs to RTL or not. If the direction was property of the locale, then we won…

[صورة] ibnesayeed: Does this change anything? It just means that the class can’t be eliminated without changing a few other things as well. But yes, what you’re saying seems correct to me.

[صورة] simon: It just means that the class can’t be eliminated without changing a few other things as well. Such as, lines 389 and 401 app/mailers/user_notifications.rb ad5d16af8 locals: { message: PrettyText.cook(message, sanitize: false).html_safe, …

Yes. I don’t know if this is a change they will want to make, but it’s good you are interested in working on this. I’ve done some work on it in the past. I got involved with it to help set up a forum, but I don’t speak a RTL language. It’s a great way to learn the Discourse code. There are still a f…

Also, I noted that in the existing TRL class there is some logic duplicated. app/models/rtl.rb 49fc54aac def enabled? site_locale_rtl? || current_user_rtl? end def current_user_rtl? SiteSetting.allow_user_l…

[صورة] simon: I don’t know if this is a change they will want to make, but it’s good you are interested in working on this. I feel that they might actually be willing to get rid of a class that does not deserve to be a class, because the class itself is not that deep rooted. If we keep the su…

I won’t go so far to say I know the code inside out, but I’ll chip in my [صورة] I looked to see if any tests might break if current_user_rtl or site_locale_rtl were removed. I found none and in fact the only place they exist in the Core code is in the models/rtl.rb file. So removing them might bre…

It looks like locale is simply a string, not an object. Hence we can’t attach properties to it. However, there are other ways to specify the direction. One is to add a direction or rtl? attribute in the config/locales/names.yml file. Another possibility is to define rtl? method in a place from wher…

For some reason I like the idea of having it in the yml file. I have no basis for the feeling other than it just seems like the logical best place for it. I tried hacking the rtl.rb file to def enabled? # site_locale_rtl? || current_user_rtl? user.effective_locale.in?(rtl_locales) end …

Why is RTL class user dependent instead of locale?

Development

simon 11 ديسمبر 2016، 3:37ص 2

I think the RTL class is used in UserNotifications for adding the rtl class to emails.

الموضوع		الردود	مرات العرض
Digest Emails are not supporting RTL Product Support activity-summary	2	658	26 نوفمبر 2019
Layout for RTL users can't be set per user, only at the whole site level UX	10	1530	28 أكتوبر 2019
Emails for rtl languages have ltr direction Bug	19	5119	17 يونيو 2017
Setting input direction in UI Feature	1	913	31 مارس 2017
Recommended way to handle RTL mixed with LTR languages Product Support	30	14512	20 سبتمبر 2020

Why is RTL class user dependent instead of locale?

الموضوعات ذات الصلة