The discussion revolves around an issue with specifying a port for an embeddable host given an IP, which results in an error. kennym encountered this problem when trying to add an embeddable host with the port number included (http://192.168.1.167:3000), but it worked when the port number was removed (http://192.168.1.167). A video demonstrating the issue is available at https://gfycat.com/GrotesquePleasantImpala. kennym created a PR (https://github.com/discourse/discourse/pull/4759) to address the issue, which was reviewed by codinghorror and merged by eviltrout after determining there was no security risk.
When I try to add an embeddable host with the host: http://192.168.1.167:3000 then it tells me that the host is invalid.
If I remove the port number, as so: http://192.168.1.167, then everything works.
Here’s a video of the issue in detail:
https://gfycat.com/GrotesquePleasantImpala
I’m currently working on Add scope for human users. · discourse/discourse@4d4a1a1 · GitHub on Mac with Vagrant.
PR: FIX: Allow ports for embed host IPs by kennym · Pull Request #4759 · discourse/discourse · GitHub
Does this seem OK to you @eviltrout? Any security risk here?
Looks great, merged!