Specifying port for embeddable host given an IP results in error


(Kenny Meyer) #1

When I try to add an embeddable host with the host: http://192.168.1.167:3000 then it tells me that the host is invalid.

If I remove the port number, as so: http://192.168.1.167, then everything works.

Here’s a video of the issue in detail:


GrotesquePleasantImpala

I’m currently working on Add scope for human users. · discourse/discourse@4d4a1a1 · GitHub on Mac with Vagrant.


(Kenny Meyer) #2

PR: FIX: Allow ports for embed host IPs by kennym · Pull Request #4759 · discourse/discourse · GitHub


(Jeff Atwood) #3

Does this seem OK to you @eviltrout? Any security risk here?


(Robin Ward) #4

Looks great, merged!


(Jeff Atwood) #5