Specifying port for embeddable host given an IP results in error

When I try to add an embeddable host with the host: http://192.168.1.167:3000 then it tells me that the host is invalid.

If I remove the port number, as so: http://192.168.1.167, then everything works.

Here’s a video of the issue in detail:

I’m currently working on https://github.com/discourse/discourse/commit/4d4a1a1552444ff1d6cb47d019950ad01e72547f on Mac with Vagrant.

PR: https://github.com/discourse/discourse/pull/4759

2 Likes

Does this seem OK to you @eviltrout? Any security risk here?

2 Likes

Looks great, merged!

4 Likes