It seems that Discourse doesn’t see that Google image links are images in order to know to download them locally. I noticed this first on a multi-site instance, and then checked on try. Here’s this url https://photos.app.goo.gl/KXa79xi3R82sjisX8 that renders beautifully into an image, but it never…

Interesting … what about flickr? <a href="https://www.flickr.com/photos/71459666@N00/24130109/in/photolist-39upZ-764KDt-9x8s8C-38F3n-6RXyP7-dtXsgb-7RuMHf-6P3ubv-7VCArQ-86KvnT-75Nu1a-6PjCap-9467mt-b7smme-9U4hyo-UTybxc-ciZKqS-cN2N2L-7R1VwU-5sNy2b-NAGPU-5nHaHi-mD2Cym-7wCS4D-bWjFot-7qxZhx-75pnnu-fvEZht-5J9PBr-5nMskG-5nfxsR-9rgKnw-3QMfuQ-eNTHnK-5nMsnL-5f3Fwi-8Twkoa-7KTVeS-5nMsj3-5nHbJg-5UsFtC-BPD2R-5nMspN-5PR1np-7uqf47-5pKHU2-7dHyvU-av656a-5nMs1L-6ojLbT" target="_blank" rel="noopener" class="onebox"> [Imgur]

I think this is not specific to google, its more of an all onebox thing, @techAPJ any idea why this is happening. Also … behold my ninja hamster above, so cute, yet so dangerous.

Kind of a scope creep, let’s focus on other things for now. It’s been this way forever.

Yeah I remember this popping up before, I am just a bit surprised cause I thought @vinothkannans fixed this a while back. https://meta.discourse.org/t/download-images-for-oneboxes-as-well-if-download-images-is-set/21103/30?u=sam

Oh aha maybe @vinothkannans can take a peek next week if he already worked on it before.

We already downloading onebox images. The issue here is “Google Photos” not using file extension in the image URLs. So we are unable to fetch it from the post content. Anyway we can achieve it by adding a special case for Google. Added to my list. [image] sam: Interesting … what about flickr? …

[image] vinothkannans: Anyway we can achieve it by adding a special case for Google. Why do we need this though? Should we not just try to download everything that is <img src="https://site.com/i_must_be_an_image">, it will come back with a mime type.

I’ve fixed it here. https://github.com/discourse/discourse/commit/6aee22b88f61184c0fdf03c7fc16c4cfea4ed5cd https://github.com/discourse/onebox/commit/ebb4b54548d51bb63923959a16f106f787f2ad48

Google photos images not downloaded

Product Support

vinothkannans (Vinoth Kannan) July 12, 2018, 6:56am 12

Yes, good question. We should download everything in img src. I will investigate further

Topic		Replies	Views
Onebox support for new Google Photos Feature onebox	17	5366	April 25, 2019
Why some images aren't automatically downloaded? Feature	7	1612	September 22, 2015
Fetching images from newspaper websites is failing Product Support	2	629	August 16, 2022
Downloading of .webp images in oneboxes is broken Bug	9	1823	February 11, 2021
Discourse not downloading remote images anymore? Product Support	6	1007	July 4, 2022

Google photos images not downloaded

Related topics