Admin.groups.manage.membership.automatic not replaced

UX
1

The image shows a screenshot of a computer or mobile device displaying a webpage, likely a social media platform. (Captioned by AI)
The image shows a screenshot of a computer or mobile device displaying a webpage, likely a social media platform. (Captioned by AI)1774×433 115 KB

Should this be visible for everyone?

2 Likes
2

I see it on the Admins group page as well.

image
image1170×1319 82.3 KB

3

I think it appears at all automatic group pages. I chose “moderators” as the example for my screenshot, but staff, admins, and the trust level groups are also affected

1 Like
4

On mobile, if you can message the group, the broken text moves the message button.

_20240920_141814
_20240920_141814720×522 43.7 KB

1 Like
5

note… added a priority tag here so we will have a look in the upcoming few weeks.

1 Like
6

I think it’s quite easy to fix.

At the moment, the tooltip is visible for everyone, but it uses a string for the admin section:

image
image1078×160 9.36 KB

I think the information is only relevant to those who can add group members. This can include admins, group owners, and, depending on the moderators manage categories and groups setting, moderators. I believe that automatic groups cannot have owners, so anyone allowed to manage the automatic group should also be able to access the admin section string, and it could be hidden for everyone else.

+       {{#if this.canManageGroup}}
          {{#if this.model.automatic}}
            <DTooltip class="admin-group-automatic-tooltip">
              <:trigger>
                {{d-icon "gear"}}
                {{i18n "admin.groups.manage.membership.automatic"}}
              </:trigger>
              <:content>
                {{i18n "admin.groups.manage.membership.automatic_tooltip"}}
              </:content>
            </DTooltip>
          {{/if}}
+       {{/if}}
4 Likes
7

Feel free to PR away @Moin :wink:

8

I am not able to write tests :frowning:

9

No worries, I’ll take it then :wink:

1 Like
11
12

Thanks, this will be fixed once this gets merged

13

It was missing a check to ensure the current user is an admin, since only admins can manage automatic groups.

Interesting. I thought moderators could too if moderators manage categories and groupsis enabled. The “manage” tab is visible for them.

Screenshot_20241206_151909_Firefox
Screenshot_20241206_151909_Firefox1737×1079 171 KB

That’s why I thought explaining why they cannot add members like they are able at other groups is helpful.

1 Like
14

Automatic groups are handled differently I think, I saw some checks in the code that required admin, though that might be leftovers…

@hugh / @martin do either of you know who is able to manage automatic groups?

15

This topic was automatically closed after 16 hours. New replies are no longer allowed.

16

I think the site setting Moin mentioned does allow this, here is the relevant guardian check:

But in the client, we are sending mixed messages :sweat_smile:

Here is a followup PR to change to check canManageGroup, and also update the user model version of canManageGroup to be more sensible (the only place using that is from this group controller):

4 Likes