Admin.groups.manage.membership.automatic non sostituito

martin · 9 Dicembre 2024, 1:41am

Penso che l’impostazione del sito menzionata da Moin lo consenta, ecco il controllo guardian pertinente:

lib/guardian/group_guardian.rb

4ddf7e61f


      
          def can_admin_group?(group)
            is_admin? ||
              (
                SiteSetting.moderators_manage_categories_and_groups && is_moderator? && can_see?(group) &&
                  group.id != Group::AUTO_GROUPS[:admins]
              )
          end

Ma nel client, stiamo inviando messaggi contrastanti

github.com/discourse/discourse

app/assets/javascripts/discourse/app/models/user.js

4ddf7e61f


      
          canManageGroup(group) {
            return group.get("automatic")
              ? false
              : group.get("can_admin_group") || group.get("is_group_owner");
          }

github.com/discourse/discourse

app/assets/javascripts/discourse/app/controllers/group.js

4ddf7e61f


      
          @discourseComputed("model", "model.automatic")
          canManageGroup(model, automatic) {
            return (
              this.currentUser &&
              (this.currentUser.canManageGroup(model) ||
                (model.can_admin_group && automatic))
            );
          }

Ecco una PR di follow-up per modificare il controllo canManageGroup, e anche per aggiornare la versione del modello utente di canManageGroup in modo più sensato (l’unico posto che utilizza questo è dal controller di gruppo):

github.com/discourse/discourse

FIX: Allow anyone who can manage groups to see Automatic tooltip

main ← issue/manage-groups-followup

opened 01:40AM - 09 Dec 24 UTC

martin-brennan

+56 -37

Followup 35ecd0335c70e4f008ae86ec5804dc60dbf41101 Since we have the moderator…s_manage_categories_and_groups setting, more than admins can manage groups, so we need to allow others to see this Automatic tooltip as well. Also fixes an inconsistency with canManageGroup between the User model and Group controller, the latter is correct, allowing management of automatic groups if can_admin_group permission is true

Argomento		Risposte	Visualizzazioni
Moderators group [en_GB.admin.groups.manage.membership.automatic_tooltip] Site feedback groups	2	38	Dicembre 4, 2024
Should it be possible to add and remove users from moderators group? UX groups	4	124	Gennaio 31, 2025
How does visibility of automatic groups work? Support	6	858	Ottobre 4, 2023
Cannot change member_visibility_level of automatic groups Bug groups	10	536	Gennaio 20, 2024
Respect the visibility settings of all automatic groups Feature groups	14	737	Ottobre 23, 2023

Admin.groups.manage.membership.automatic non sostituito

Argomenti correlati