Admin.groups.manage.membership.automatic이 대체되지 않음

martin · 12월 9, 2024, 1:41오전

Moin이 언급한 사이트 설정이 이 기능을 허용하는 것 같습니다. 관련 가디언 체크는 다음과 같습니다:

lib/guardian/group_guardian.rb

4ddf7e61f


      
          def can_admin_group?(group)
            is_admin? ||
              (
                SiteSetting.moderators_manage_categories_and_groups && is_moderator? && can_see?(group) &&
                  group.id != Group::AUTO_GROUPS[:admins]
              )
          end

하지만 클라이언트에서는 모호한 메시지를 보내고 있습니다

github.com/discourse/discourse

app/assets/javascripts/discourse/app/models/user.js

4ddf7e61f


      
          canManageGroup(group) {
            return group.get("automatic")
              ? false
              : group.get("can_admin_group") || group.get("is_group_owner");
          }

github.com/discourse/discourse

app/assets/javascripts/discourse/app/controllers/group.js

4ddf7e61f


      
          @discourseComputed("model", "model.automatic")
          canManageGroup(model, automatic) {
            return (
              this.currentUser &&
              (this.currentUser.canManageGroup(model) ||
                (model.can_admin_group && automatic))
            );
          }

canManageGroup 체크로 변경하기 위한 후속 PR입니다. 또한 canManageGroup의 사용자 모델 버전을 더 합리적으로 업데이트했습니다(이 그룹 컨트롤러에서만 해당 메서드를 사용함):

github.com/discourse/discourse

FIX: Allow anyone who can manage groups to see Automatic tooltip (#30174)

main ← issue/manage-groups-followup

merged 03:21AM - 09 Dec 24 UTC

martin-brennan

+56 -37

Followup 35ecd0335c70e4f008ae86ec5804dc60dbf41101 Since we have the moderator…s_manage_categories_and_groups setting, more than admins can manage groups, so we need to allow others to see this Automatic tooltip as well. Also fixes an inconsistency with canManageGroup between the User model and Group controller, the latter is correct, allowing management of automatic groups if can_admin_group permission is true

글		댓글	조회수
Moderators group [en_GB.admin.groups.manage.membership.automatic_tooltip] Site feedback groups	1	110	11월 23, 2024
Should it be possible to add and remove users from moderators group? UX groups	3	249	1월 31, 2025
How does visibility of automatic groups work? Product Support	5	1022	10월 4, 2023
Cannot change member_visibility_level of automatic groups Bug groups	7	757	1월 17, 2024
Respect the visibility settings of all automatic groups Feature groups	14	1023	10월 23, 2023

Admin.groups.manage.membership.automatic이 대체되지 않음

Related topics