Admin.groups.manage.membership.automatic 未被替换

martin · 2024 年12 月 9 日 01:41

我认为 Moin 提到的站点设置允许这样做，这是相关的 guardian 检查：

lib/guardian/group_guardian.rb

4ddf7e61f


      
          def can_admin_group?(group)
            is_admin? ||
              (
                SiteSetting.moderators_manage_categories_and_groups && is_moderator? && can_see?(group) &&
                  group.id != Group::AUTO_GROUPS[:admins]
              )
          end

但在客户端，我们发送了相互矛盾的消息

github.com/discourse/discourse

app/assets/javascripts/discourse/app/models/user.js

4ddf7e61f


      
          canManageGroup(group) {
            return group.get("automatic")
              ? false
              : group.get("can_admin_group") || group.get("is_group_owner");
          }

github.com/discourse/discourse

app/assets/javascripts/discourse/app/controllers/group.js

4ddf7e61f


      
          @discourseComputed("model", "model.automatic")
          canManageGroup(model, automatic) {
            return (
              this.currentUser &&
              (this.currentUser.canManageGroup(model) ||
                (model.can_admin_group && automatic))
            );
          }

这是一个后续的 PR，用于更改检查 canManageGroup，并更新 user model 版本中的 canManageGroup 以使其更合理（唯一使用该版本的地方来自此 group controller）：

github.com/discourse/discourse

FIX: Allow anyone who can manage groups to see Automatic tooltip

main ← issue/manage-groups-followup

opened 01:40AM - 09 Dec 24 UTC

martin-brennan

+56 -37

Followup 35ecd0335c70e4f008ae86ec5804dc60dbf41101 Since we have the moderator…s_manage_categories_and_groups setting, more than admins can manage groups, so we need to allow others to see this Automatic tooltip as well. Also fixes an inconsistency with canManageGroup between the User model and Group controller, the latter is correct, allowing management of automatic groups if can_admin_group permission is true

话题		回复	浏览量
Moderators group [en_GB.admin.groups.manage.membership.automatic_tooltip] Site feedback groups	2	38	2024 年12 月 4 日
Should it be possible to add and remove users from moderators group? UX groups	4	124	2025 年1 月 31 日
How does visibility of automatic groups work? Support	6	858	2023 年10 月 4 日
Cannot change member_visibility_level of automatic groups Bug groups	10	536	2024 年1 月 20 日
Respect the visibility settings of all automatic groups Feature groups	14	737	2023 年10 月 23 日

Admin.groups.manage.membership.automatic 未被替换

相关话题