Server Error accessing topic revisions on a specific topic

zogstrip · 30.Ноябрь.2024 14:49:16

Thanks for the report @paulofonseca.eth, this will be fixed by

github.com/discourse/discourse

PERF: only diff HTML / Markdown when needed

main ← perf-posts-revisions

merged 03:30PM - 30 Nov 24 UTC

ZogStriP

+44 -33

When serializing the `body_changes` in the `PostRevisionSerializer`, we create t…wo diffs: one for the `cooked` and another one for the `raw` version of the post. Inside `DiscourseDiff`, we generate both `html` and `markdown` diffs when we only need the `html` diffs for the `cooked` version of the post and the `markdown` diff for the `raw` version of the post. This solves the issue repored in https://meta.discourse.org/t/server-error-accessing-topic-revisions-on-a-specific-topic/339185 where some revisions would return 500 because of a `ArgumentError : Attributes per element limit exceeded` exception when trying to generate the `html` diff on a very large `raw`.

Тема		Ответов	Просм.
Unable to View Edit History - Continuous Loading Issue Support	15	183	01.08.2024
Happening again: Revision is hidden/inaccessible Bug	0	53	05.04.2025
Pull or quote content from within the revision history Development rest-api	1	346	14.11.2023
Title missing from revisions dialog Bug	2	861	02.03.2015
Endless loading of post history when latest revision is hidden/inaccessible Bug fixed	10	537	30.08.2024

Server Error accessing topic revisions on a specific topic

Связанные темы