404 error when you revert a tag name after changing it without reloading the page

martin · January 29, 2025, 2:36am

Thanks for the detailed report, I’ve got a fix for this now which should be merged soon:

github.com/discourse/discourse

UX: Fix tag revert rename 404 error

discourse:main ← discourse:fix/tag-rename-404

opened 02:35AM - 29 Jan 25 UTC

martin-brennan

+70 -2

Changing a tag name and reverting it to a previous tag name choice on the same …screen (meaning, without reloading the page) causes a 404 error. Reproduction steps: * Open an existing tag page https://your-discourse.com/tag/a * Click the wrench, change the name and save * Open edit again, revert the name to the original tag name * 404 error This was happening because of the way we find existing objects in our store. Tags are using the name as the id/primary key unlike other records in the UI. When we get the existing object from the store we throw away the "new" ID, so we ended up with the old tag ID on the existing object, which led to a 404. To fix it we can just manually set the tag ID to what it is supposed to be from params in the tag show route. c.f. https://meta.discourse.org/t/404-error-when-you-revert-a-tag-name-after-changing-it-without-reloading-the-page/342559

Topic		Replies	Views
The change of from "tags" to "tag" in its URL affects my Discourse since they are linked in many posts. How can I automatically change them? Support	12	780	August 16, 2022
Switch from TAGS to TAG broke links in posts and "Delete Unused Tags" Bug	8	1079	July 11, 2022
Change title tag of the 404 page Dev	5	779	May 21, 2022
How to Redirect all 404 pages to home? Installation	14	1701	August 8, 2023
Can't Edit Tag Names Bug tags	3	271	December 9, 2023

404 error when you revert a tag name after changing it without reloading the page

Related topics