Ошибка 404 при отмене изменения имени тега без перезагрузки страницы

martin · 29.Январь.2025 02:36:18

Спасибо за подробный отчёт. У меня уже есть исправление, которое скоро будет слито:

github.com/discourse/discourse

UX: Fix tag revert rename 404 error (#31049)

main ← fix/tag-rename-404

merged 12:06AM - 30 Jan 25 UTC

martin-brennan

+70 -2

Changing a tag name and reverting it to a previous tag name choice on the same …screen (meaning, without reloading the page) causes a 404 error. Reproduction steps: * Open an existing tag page https://your-discourse.com/tag/a * Click the wrench, change the name and save * Open edit again, revert the name to the original tag name * 404 error This was happening because of the way we find existing objects in our store. Tags are using the name as the id/primary key unlike other records in the UI. When we get the existing object from the store we throw away the "new" ID, so we ended up with the old tag ID on the existing object, which led to a 404. To fix it we can just manually set the tag ID to what it is supposed to be from params in the tag show route. c.f. https://meta.discourse.org/t/404-error-when-you-revert-a-tag-name-after-changing-it-without-reloading-the-page/342559

Тема		Ответов	Просм.
Can't rename tag: The requested URL or resource could not be found Bug	8	812	11.11.2020
Rename tag not working as expected Bug	3	801	23.04.2021
Tag shows up in Tag list, but 404s when clicked Support tags	4	386	31.07.2022
Unable to create tag when name is in existing tag with underscore Bug	8	1301	29.10.2016
Can't Edit Tag Names Bug tags	2	323	06.12.2023

Ошибка 404 при отмене изменения имени тега без перезагрузки страницы

Связанные темы