Later today I am going to be merging our new post rendering engine into master. Swapping out Ember/HTMLBars for a virtual-dom based renderer provides us with a huge performance increase, but it also has the side effect of being incompatible with how plugins were previously made. While doing this w…

[изображение] fantasticfears: Right after the reading, it’s hard to understand the version “0.1” here. It’s not connected with Discourse version. Why? It just sounds wrong… It is the version of the API you coded against, not Discourse. This distinction allows Discourse to provide an API objec…

[изображение] eviltrout: This is trickier than it sounds. For example, let’s say a plugin says it supports 1.3 of Discourse. Is it assumed that it will work with any later version? Because down the road we will certainly deprecate and change some APIs as we build new features. It’s good for the…

[изображение] eviltrout: I just tried your snippet and it still seems to work on the latest build of Discourse. Long term I do want to allow some customizations built that way, but I have to get around to it. Thank you for the prompt reply. No guarantees of course, but how long do you think w…

[изображение] eviltrout: What were you thinking? api.siteSettings? Sounds good. Again, if you thinks it’s not worth exposing. It’s reasonable as the same reason you talk about the api version. The site settings may change. But the thing actually I want to touch is the plugin enable settings.…

This is great! I’ve always been a bit anxious that the hooks and outlets I’ve been using for plugins would suddenly disappear. Just wanted to share my experience with this playing around with it this morning. For my ratings plugin , I had to migrate this template for the poster-name-right outlet (w…

Sorry for the reply below with many quotes, but there’s a lot to respond to! [изображение] ccdw: Thank you for the prompt reply. No guarantees of course, but how long do you think will you continue to support that type of snippet? To be honest I’ve never been fully comfortable supporting tha…

[изображение] eviltrout: Yes I agree that’s a bit funky. In this case, showRating is a property on the controller right? Is it there because people can enable/disable it on the topic? You can disable/enable ratings for a category or by adding a tag to a topic. [изображение] [изображение] …

@cpradio I see you’ve been busy adding API to plugins :thumbsup: I missed the “tests-passed” bit and tried while running master. :sadpanda: I got TypeError: withPluginApi is not a function Have you found a way to make this conditional? import { withPluginApi } from 'discourse/lib/plugin-api';…

Do you mean beta or stable? As master should have plugin-api. As it is a branch higher than tests-passed. Both beta and master are below, so they wouldn’t have it. To answer your question, I haven’t toyed with that aspect of it yet. @eviltrout , is there a concern here? As if the lib doesn’t exist i…

Ah, it is in master here https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/plugin-api.js.es6 I could have sworn I did a git fetch upstream but I must have done so on a different copy of Discourse than I thought I had. EDIT I really should get a new eyeglass …

A versioned API for client side plugins

Разработка

codinghorror (Jeff Atwood) Разделил(а) эту тему 25.Февраль.2016 21:49:15 23

7 posts were split to a new topic: New vdom rendering missing inbound/outbound CSS classes in gutter

New vdom rendering missing inbound/outbound CSS classes in gutter

Тема		Ответов	Просм.
Theme-Component v Plugin: What's the difference Development	22	5593	09.06.2020
Developing Discourse Plugins - Part 1 - Create a basic plugin Developer Guides plugin-guides , tutorial	32	82141	08.07.2025
Upcoming post menu changes - How to prepare themes and plugins Development dev-news	13	922	01.04.2025
Developing Discourse Plugins - Part 5 - Add an admin interface Developer Guides plugin-guides , tutorial	47	26125	24.09.2024
Modernizing inline script tags for templates & JS API Development dev-news	47	4140	25.03.2026

A versioned API for client side plugins

Связанные темы