Banner dismiss icon isn’t marked up as a button

I posted over at users.rust-lang.org about this – apparently it’s a Discourse issue, so I’m reposting it here.

The banners sometimes displayed at the top of the page:

have a close button that isn’t marked up as a button, which is an accessibility issue.

I can’t dismiss the banner with Vimium, and I imagine it also causes problems for users who don’t use a traditional mouse due to a disability.

Is there any way this banner can be made more accessible?

8 Likes

What do you think @awesomerobot?

3 Likes

Yeah this makes sense, looks like our modals have non-button close icons as well, I can update those too.

4 Likes

This should do the trick, and I was able to do some minor style cleanup as well. Thanks for reporting this @anowlcalledjosh!

7 Likes