I don’t like (no pun intended) this personally. When I open the forums in the morning, many times I’ll have more notifications than fit in the menu. Likes get pushed to the bottom (due to messages being prioritized, which I like). If likes were marked read automatically simply by opening the menu, I’d potentially miss some because they weren’t even on the menu. Keeping the highlight allows me to go into my notifications page and ensure I read everything,
And the logic should check how many notifications before showing it…? And grey it out or hide it once you’ve pressed it like the notifications page does?
If we’re using the Facebook as our model, no, not necessary. Facebook always displays “Mark all as Read” as a clickable blue link regardless of if there are any notifications to mark read.
I think Neil’s suggested location for the “dismiss” link makes more sense - that’s where people would look for notifications actions. Next to log out might confuse them. Their reaction may be “huh? dismiss what?” Maybe worth asking a civilian…
Rather than random speculation, which I don’t agree with for a variety of reasons, we should get it out there and get feedback first.
I was also thinking we have dropped this “show me more…” text pattern in favor of a down chevron anyways, so that is another reason not to do what you’re proposing. Like so:
One less translation, and consistent with a few other places we have a logical “continue showing me more of X at the bottom of this, because there are more not shown here” pattern.
The dismiss link and down-chevron link are live now on Try.
We can tweak the position and label of the Dismiss button based on the principles of complaint-driven development. Now that the down arrow is there, I think the Dismiss button makes sense where it is.
I don’t think that’s the dismiss button, that’s the menu trying to decide the correct height? e.g. that was not Neil’s new thing, but Robin’s original code?
The panel doesn’t know if there are notifications so dismiss isn’t shown until they’re loaded. Logic can be reversed to show it until 0 notifications load I guess.