Add `-moz-tab-size` until Firefox supports `tab-size`

Firefox doesn’t support the tab-size attribute, so code in text boxes show 8-space-wide-tabs.

There is an open ticket in Bugzilla tracking this (Bug 737785), but it’s blocked on some implementation changes. TL;DR: Firefox only implements non-prefixed, standardized CSS attributes if it meets the spec, which it currently doesn’t.

Until Firefox implements tab-size, could Discourse add in -moz-tab-size in its style sheets?

Here’s a sample:

def hello_world():
	print("Hello, world!")
#2345678

And here’s a screenshot of how it renders on FF nightly 77.0a1 (2020-04-23) (64-bit):

image

6 Likes

Seems ok to me cc @awesomerobot @sam

2 Likes

Good catch @AMomchilov! It’s been done here:

https://github.com/discourse/discourse/commit/4e1c2fbd18a833ea56a83047dfbe41bb7355a742

7 Likes

Thanks!

Out of curiosity, do you guys commit straight to master, without a pull request?

It’s fixed :slight_smile:

image

1 Like

This topic was automatically closed after 20 hours. New replies are no longer allowed.