Adding an invalid tag to a topic creates a whisper post

Внести вклад Ошибка
,
1

Reproduction steps:

  1. Turn on this setting
    The image shows instructions for creating a post or a whisper post when a topic's category or tags change, requiring whisper posts to be enabled. (Captioned by AI)
  2. Limit a category to only a specific set of tags
  3. Edit a subject of an existing topic in that category
  4. Create a new tag by entering a new tag name into the tag area
  5. Save the subject

Althought it seemed it was possible to add the tag, it won’t appear after saving (as it was not allowed). But when you look at the end of the topic, a whisper post was created that mentions the change of the tag.

Expected behavior: The whisper should not mention tags that were not created at all.

4 лайка
2

Interesting edge case, I wonder if we should put a pr-welcome on this @hugh ?

2 лайка
3

Not sure if it is technically related but I also found another whisper related issue before.

4

Yeah, I added pr-welcome to this. Thanks for reporting @tvavrda :slight_smile:

2 лайка
5

I’ve opened a PR on GitHub for this: FIX: Ensure tag diffs use persisted topic tags by TethysPlex · Pull Request #35187 · discourse/discourse · GitHub

2 лайка
8

bump.

could anyone review this?

3 лайка
9

I’ll see who might be available to take a look.

2 лайка
12

Sorry for the delay @TethysPlex and thanks for the PR.

I have reviewed, made some light tweaks and merged it :+1:

3 лайка
14

This topic was automatically closed after 15 hours. New replies are no longer allowed.