Adding new emojis


#1

can’t seem to add new emojis… was working fine before update.


(Jeff Atwood) #2

Can we repro @jomaxro?


(Joshua Rosenfeld) #3

Sure can! That should be a nacho emoji called test:
image


(Jeff Atwood) #4

Ok this also needs some fixing @eviltrout


#5

so much sadness… but, happy to help identify an issue!

emojis ho!


(Joffrey Jaffeux) #7

I can probably take this of robin’s plate


(Joffrey Jaffeux) #8

@sam this commit broke it: FEATURE: uploads are processed a faster · discourse/discourse@eb428ef · GitHub Basically we are trying to access the url of the file when it hasn’t been uploaded yet.

I propose the following fix, could you please review it ? I don’t think a loading indicator is needed here, it’s a rare operation and very fast, it would make the UI/code more complex for very limited added value.

Note: I also took this opportunity to refactor a little bit the file to our current coding style, let me know if you want a separate commit for this.


(Sam Saffron) #9

This isn’t right it should not use message bus here, will look on Monday


(Sam Saffron) #13

Fixed per:

Sorry about it, my bad I broke it.


(Sam Saffron) #15

This topic was automatically closed after 31 hours. New replies are no longer allowed.