Adding new emojis

[8BIT]

can’t seem to add new emojis… was working fine before update.

[codinghorror (Jeff Atwood)]

Can we repro @jomaxro?

[jomaxro (Joshua Rosenfeld)]

Sure can! That should be a nacho emoji called test:

[codinghorror (Jeff Atwood)]

Ok this also needs some fixing @eviltrout

[8BIT]

so much sadness… but, happy to help identify an issue!

emojis ho!

[joffreyjaffeux]

I can probably take this of robin’s plate

[joffreyjaffeux]

@sam this commit broke it: https://github.com/discourse/discourse/commit/eb428ef54dcc1d0d74f5d4a0d3fd12f1122dab65#diff-2493f61f43374781bb8d3ed4ae50ded9L21 Basically we are trying to access the url of the file when it hasn’t been uploaded yet.

I propose the following fix, could you please review it ? I don’t think a loading indicator is needed here, it’s a rare operation and very fast, it would make the UI/code more complex for very limited added value.

https://github.com/discourse/discourse/pull/5440

Note: I also took this opportunity to refactor a little bit the file to our current coding style, let me know if you want a separate commit for this.

[sam (Sam Saffron)]

This isn’t right it should not use message bus here, will look on Monday

[sam (Sam Saffron)]

Fixed per:

https://github.com/discourse/discourse/commit/5e90abfaea9e6261b4b256f0cdb4f71f3be739c3

Sorry about it, my bad I broke it.