After editing “Saving” bar is stuck

Bug
1

Since a few days I noticed that sometimes after editing a post, the “Saving” bar is stuck at the bottom.

I’ve had this on Chrome desktop and Mobile safari so far.

Sounds familiar to anyone?

2

Can you give us any more info?

  • Is this on more than one discourse instance?
  • any messages in the browser console?
3

Just one instance, I think I found the error in the logs. It seems related to Discourse Staff Alias. The plugin is enabled but not used in the post where this happens.

Message (2 copies reported)

LocalJumpError (unexpected return)
lib/plugin/instance.rb:491:in `block in on'
lib/discourse_event.rb:12:in `block in trigger'
lib/discourse_event.rb:12:in `trigger'
lib/post_revisor.rb:659:in `post_process_post'
lib/post_revisor.rb:254:in `revise!'
app/controllers/posts_controller.rb:259:in `update'
app/controllers/application_controller.rb:414:in `block in with_resolved_locale'
app/controllers/application_controller.rb:414:in `with_resolved_locale'
lib/middleware/omniauth_bypass_middleware.rb:74:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:369:in `call'
config/initializers/100-quiet_logger.rb:20:in `call'
config/initializers/100-silence_logger.rb:29:in `call'
lib/middleware/enforce_hostname.rb:24:in `call'
lib/middleware/request_tracker.rb:228:in `call'

Backtrace

plugins/discourse-staff-alias/plugin.rb:187:in `block (2 levels) in activate!'
lib/plugin/instance.rb:491:in `block in on'
lib/discourse_event.rb:12:in `block in trigger'
/usr/local/lib/ruby/3.2.0/set.rb:511:in `each_key'
/usr/local/lib/ruby/3.2.0/set.rb:511:in `each'
lib/discourse_event.rb:12:in `trigger'
lib/post_revisor.rb:659:in `post_process_post'
lib/post_revisor.rb:254:in `revise!'
app/controllers/posts_controller.rb:259:in `update'
actionpack (7.0.4.3) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
2 Likes
4

I’ve noticed that on my instance, enabling this plugin causes edit operations to return a 500 Internal Server Error

2 Likes
6

I’ve slipped your post over to here @Lhc_fl to group them together, and recategotised it as a bug @MarcP :+1:

2 Likes
7

Thanks for the bug report. Sadly the bug was introduced due to FEATURE: Allow posts to change ownership to the staff alias user by nattsw · Pull Request #47 · discourse/discourse-staff-alias · GitHub.

We’ve fixed it here

FIX: Events should not return by nattsw · Pull Request #48 · discourse/discourse-staff-alias · GitHub.

6 Likes
8

This topic was automatically closed after 15 hours. New replies are no longer allowed.