Thanks Tarek!
Can you remove the reply all button change?
My second point is just that there is no reply to sender functionality. If I were to hit reply it would go to discourse, not directly to the sender by email, bypassing diacourse. Make sense?
Thanks Tarek!
Can you remove the reply all button change?
My second point is just that there is no reply to sender functionality. If I were to hit reply it would go to discourse, not directly to the sender by email, bypassing diacourse. Make sense?
try editing this file:
thanks, tarek! what about the second point? if I’m right then there’s no need for me even to have this plugin turned on. Mailing list mode seems to not be affected.
I’ll watch it for a few days and let you know what happens. ![]()
I’m not sure how that comes to pass for you. For me, obviously it works as advertised. Did you perhaps not enable the plugin? settings > plugins > replyto-individual enabled
yep - it’s enabled.
does the plugin work with mailing list mode turned on?
Yes. Not sure what’s happening on your installation there.
Hello all,
For those using this plugin, it is currently known to be broken. I’m working on fixing it at the moment.
Did it break a while ago, or did 2.1.2 break it? Wondering if I should hold off upgrading.
It broke in ~ August. It’s now fixed, so go ahead.
The plugin is now working again. Here’s the issue if for some reason one is bored and interested:
https://github.com/tareko/discourse-replyto-individual/issues/1
I spoke too soon about this bug being fixed. For some reason, I cannot get a “Reply-To” header added into my email properly.
The current lines in question are these:
if allow_reply_by_email?
result[ALLOW_REPLY_BY_EMAIL_HEADER] = true
if @opts[:private_reply] == true
result['Reply-To'] = reply_by_email_address
else
p = Post.find_by_id @opts[:post_id]
result['Reply-To'] = "#{p.user.name} <#{p.user.email}>"
result['CC'] = reply_by_email_address
end
else
result['Reply-To'] = from_value
end
This section is taken from the Email::MessageBuilder class.
If I leave the Reply-To set to its default ( reply_by_email_address), then all is well. However, if it is set to anything else (even “test@test.com”, then it will simply disappear from the end email headers. Similarly, if I replace Reply-To with something else like CC, then for some reason it does not build, and instead displays: replies+%{reply_key}@emlondon.ca (note, the %{reply_key} is correctly fixed in the Reply-To.
I really have no idea a) why this behaviour is happening; and b) Why it’s happening now after working for so long - what am I missing here in the API?
I managed to fix the problem with the reply_key not being substituted using this commit, which modifies the set_reply_key method in the Email::Sender class. However, I still can’t figure out why Reply-To becomes null when I change it to anything but ‘reply_by_email_address’. It is set correctly at the end of the header_args method, but I can’t figure out where it is unset.
Any thoughts? I think @featheredtoast is the staff member I see with the most recent edits to Email::MessageBuilder
Edit: After some debugging, this appears to happen somewhere in lib/mail/sender.rb before line 86, though not sure exactly where…
Edit #2: After further debugging, I found the problem to be the following line in the Email::Sender::set_reply_key method:
@message.header['Reply-To'] =
header_value('Reply-To').gsub!("%{reply_key}", reply_key)
This method was causing a Reply-To without a reply_key to be wiped. I added a simple if statement to exclude the function if there was no “reply_key” in it. As of this moment, the plugin is back to fully working status.
최근 Discourse 업그레이드 때문에 플러그인이 깨진 것 같습니다. replies-xyz@example.com 에 더 이상 CC가 전송되지 않습니다. 이슈를 생성했습니다.
늦게 확인하게 되어 죄송합니다. 어떤 이유인지 알 수 없게 알림이 오지 않았습니다. GitHub에서 이 문제를 계속 진행하겠습니다.
이 문제는 이제 GitHub에서 수정되었습니다. 핵심은 message_builder.rb와 sender.rb의 동작 방식에 일부 변경이 생겨 플러그인의 변경 사항이 무효화되었던 것입니다. 예를 들어, reply_key 대체 시 gsub 대신 gsub!이 사용되어 ‘to’ 헤더가 사라지는 문제가 발생했습니다. 또한, 알 수 없는 이유로 CC가 2글자라는 이유로 self.custom_headers에 의해 제거되었습니다. 어딘가에 보안 기능이 작용한 걸까요? 하지만 모듈이 작동하도록 하기 위해 이를 비활성화했습니다. 새로운 버전은 github에서 확인할 수 있습니다. 버그 보고해 주셔서 감사합니다!