I think that’s his point — a button labeled “copy link” implies just that, the actual copy action. Versus e.g. “generate link” or “show link”.
But yeah this is getting to be a common pattern now, one click actually copying directly to clipboard to save the ctrl-C. Not essential but if a button says “copy link” that’s now what I’d expect it to do.