Automatic group membership and alternate emails

Jonathan5 · December 5, 2021, 9:15pm

If a user has both a primary and alternate email addresses, will automatic group membership check both these email addresses or only the primary email address?

I know I could experiment but this forum is so useful and it would be good to get a definitive answer. Thanks again.

pfaffman · December 6, 2021, 5:20pm

I’d say that it would be a bug if it didn’t behave that way. So your question is sort of like “It would be possible for there to be a bug here. Is there?”

It looks like it should behave as expected. I think that join will look at all of the user’s emails. I don’t see a spec that specifically tests it, though.

github.com

discourse/discourse/blob/main/app/models/group.rb#L1003

    
      
                end
          
          
      builder.exec
              end
            end
          end
          
          
def self.automatic_membership_users(domains, group_id = nil)
            pattern = "@(#{domains.gsub('.', '\.')})$"
          
          
  users = User.joins(:user_emails).where("user_emails.email ~* ?", pattern).activated.where(staged: false)
            users = users.where("users.id NOT IN (SELECT user_id FROM group_users WHERE group_users.group_id = ?)", group_id) if group_id.present?
          
          
  users
          end
          
          
def self.get_valid_email_domains(value)
            valid_domains = []
          
          
  value.split("|").each do |domain|
              domain.sub!(/^https?:\/\//, '')

Jonathan5 · December 6, 2021, 5:54pm

Thanks. I don’t know enough about alternate emails yet to know what to expect. But yes it’s good to hear that all emails are checked.

pfaffman · December 6, 2021, 7:46pm

Multiple emails have been supported for quite a while now, so it’s a pretty safe bet that they work like you’d think they should.

system · January 5, 2022, 7:47pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Does automatic group membership based on email domain work when user changes email? Support groups	2	826	June 12, 2018
Alternate/alternative email addresses Feature	1	759	February 13, 2022
Allow automatic group membership based on subdomain Feature	1	708	August 3, 2022
Notification of automatic group membership Support groups , notifications	1	501	December 31, 2021
How to automatically set group and primary_group for the user? Feature	2	499	May 19, 2020

Automatic group membership and alternate emails

Related topics