This sounds great! Does it really mean Amazon S3 or will it also work with S3 lookalikes like Digital Ocean Spaces and that thing that starts with M? (I think that I’d made backups push to Spaces a while ago.)
I haven’t tested it with anything other than Amazon S3. It might work on lookalikes too if they support the required APIs. DO might work – /reference/api/spaces-api/ looks promising.
I haven’t been able to get DigitalOcean Spaces to serve as my Discourse backup location. Might require extra setups than Amazon S3. Would appreciate it if someone can give me some pointers. Thanks!
Clarification on how this works when settings are changed:
When once switches from S3 to Local or vice versa, do the existing backups get transferred or are they removed or are they left alone?
When one see’s the list of backups in the Backup page is there a way to tell the location or are they all from the selected location in the setting?
What is the meaning of this setting given that backups are no longer “synced” and either on S3 or Local? Disable the removal of backups from S3 when removed locally.
Existing backups won’t be touched. You need to delete them manually if you want to free up space.
Only from the selected backup location.
The description of the s3_disable_cleanup setting needs an update. It disables the removal of backups from S3 and makes the system ignore the value of maximum_backups when backup_location is set to S3.
I think we could actually remove the s3_disable_cleanup setting and allow disabling the cleanup by setting maximum_backups to 0. That would make it work for all backup locations the same way.
That makes sense to remove the option and use zero to disable removal of back ups. A follow up clarification on this, when one changes the settings, say from 120 days to 30 days, would that trigger an automatic cleanup of all the back ups?
Sorry, let me rephrase my question. When I change the maximum back ups from 120 to 30, the next time when it backs up, will it delete anything older than the last 30 back ups?
