Brand header theme component breaks page layout on static and no_ember pages

[amotl (Andreas Motl)]

Hi there,

@vinothkannans, the main author of the brand header theme component is already aware of the problem:

@vinothkannans

I think we should probably spend some time and rewrite this so it no longer leans on the plugin interface and works on 404 pages and other pages without ember.

I think this is very related to the above. It’s already in my list for long time. I will improve it soon. Thanks for the report.

Coming from there, we discovered these guys, perfectly complementing what we are up to here:

JavaScript not loading on certain pages

An example is when I visit a 404 page and the custom brand header child theme is installed. The theme component works on most pages but on this page it fails with references errors [23] After closer inspection it seems that no discourse JavaScript code is being generated on some pages e.g. 404 pages. The page in question is https://eurodiscover.eu/404 if anyone has time for a browse.

FIX: don't include theme HTML in static pages

With kind regards,
Andreas.