Broken text: en.house

Moin · October 24, 2024, 9:44pm

I deleted the account I created at try and then I saw

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/instance-initializers/logout.js#L43-L49


      
          this.dialog.alert({
            message: I18n.t("logout"),
            confirmButtonLabel: "home",
            didConfirm: logout,
            didCancel: logout,
            shouldDisplayCancel: false,
          });

I think it should be “home”

github.com

discourse/discourse/blob/main/config/locales/client.en.yml#L2210-L2212


      
          one: "Must be at least %{count} character"
          other: "Must be at least %{count} characters"

I think “home” was accidentally changed to “house” when the icon names were changed for the fa6 upgrade.

nat · October 29, 2024, 10:20am

When the house is not a home…

Thank you! Fixed with FIX: Copy when forced logout by nattsw · Pull Request #29462 · discourse/discourse · GitHub

nat · October 30, 2024, 12:00am

This topic was automatically closed after 13 hours. New replies are no longer allowed.

Topic		Replies	Views
Delete user line break is broken UX	5	458	September 6, 2022
Refresh button on "You were logged out." pop up goes to home instead UX	8	1230	April 29, 2020
Site header issue when resizing Bug	4	408	December 23, 2022
Unable to rebuild discourse due to no space left on device Installation	33	3018	December 19, 2022
Twitter, Github and normal username and password logins not working after upgrade Installation unsupported-install	35	7207	October 22, 2016

Broken text: en.house

Related Topics