Bulk tag buttons appear when tagging is disabled

(Joshua Rosenfeld) #1

The buttons to replace or append tags appear in the topic list bulk actions modal even when tagging is not enabled. Clicking on either provides a text field to type tags, which says “Loading failed” as the autocomplete option. A 404 error is thrown by the attempted tag search https://discourse.example.com/tags/filter/search?q=&limit=5&selected_tags=&filterForInput=true

(Jeff Atwood) #2

Can we still repro this @Simon_Cossar?

(Simon Cossar) #3

Yes, the Replace Tags and Append Tags options are still given when tags are disabled. If you try to enter a tag name, an error modal pops up saying ‘The requested URL or resource could not be found.’

(Jeff Atwood) #4

Is this a good starter task @sam?

(Sam Saffron) #5

Yes this feels like an easy change to me, client knows if tagging is enabled or not.

(Dan Ungureanu) #6

Hello guys,

This is a pretty long standing bug and I decided to give it a try. I just submitted this pull request.



(Sam Saffron) #7

Thanks, fix is merged!