Bundling more popular plugins with Discourse core

Announcements
54

If the error says that reactions, data explorer and solved are still in your yml file, then they likely are. If you believe you commented them out could they have been entered twice?

It’s definitely worth reviewing the config and make sure you edited the yml file which corresponds to your site.

55

Hi

I have successfully upgraded my forum to the latest 3.4.6 stable version. Prior to this, I was using the standalone discourse-oauth2-basic plugin for authentication.

There is no Oauth2 Basic login in the /admin/plugins.

image
image2112×1360 321 KB

My discourse version is 3.4.6.

image
image550×314 10.6 KB

HINT: The plugin ‘discourse-oauth2-basic’ is now bundled with Discourse and should not be included in your container configuration.
Remove the line ‘git clone GitHub - discourse/discourse-oauth2-basic: A basic OAuth2 plugin for use with Discourse’ from your containers/app.yml file, then try again.
For more information, see Bundling more popular plugins with Discourse core

I have to remove plugin discourse-oauth2-basic plugin before upgrade to 3.4.6

Could you please help me understand what might have gone wrong?

  • Did I misunderstand the process, and is the plugin still required?
  • Is there an additional step I missed to enable the core OAuth2 functionality after removing the plugin?
  • Or am I simply looking in the wrong place for the settings?

Thank you!

1 Like
56

Hmm… could it be the fact that you’re on stable?

57

Following the system prompt, I removed the discourse-oauth2-basic plugin before successfully upgrading to the 3.4.6 stable version.

However, I’ve now discovered that the configuration options for OAuth 2 Basic are missing from the admin dashboard.

1 Like
58

If you’re on stable, then none of this topic will apply until after the next stable release in early August. So you should add oauth2-basic back to your app.yml. The original failure must have been for some other reason.

Unfortunately the ‘hint’ logic is not very smart, and isn’t aware of stable vs. tests-passed.

4 Likes
59

Me too but What we can do about this right? lol I think that more native resources aka plugins even disabled it’s not a good solution to help beginners to there will self-host.

2 Likes
60

@nat Look this, my quote translation and my reply

3 Likes
61

No matter how I tried to comment out the clone lines in the plugins sections but it was reading that lines as I wanted to install the plugins. What did I do? Remove the line and finally worked.

When you upgrade you need to check the list of plugins included in the core of Discourse to don’t add it in the plugins section to install or remove that line if you have it in your app.yml file.

2 Likes
62

I think as these are Pre Installed. There should be options that seperate these :electric_plug: from the installed List. As the Installed list are removable vs only being abled to be disabled.

Maybe for core merged plugins should be under something like Featured plugins. Or Core Plugins.

With of course maybe an All filter.

63

Their suggestion is not ideal, but it does work. Example:

## Plugins go here
## see https://meta.discourse.org/t/19157 for details
hooks:
  after_code:
    - exec:
        cd: $home/plugins
        cmd:
          - git clone https://github.com/discourse/docker_manager.git
          - git clone https://github.com/pfaffman/discourse-allow-pm-to-staff.git
          #- git clone https://github.com/discourse/discourse-hcaptcha.git
          #- git clone https://github.com/discourse/discourse-calendar.git
          - rm -rf discourse-adplugin
          - rm -rf discourse-affiliate
          - rm -rf discourse-ai
          - rm -rf discourse-apple-auth
          - rm -rf discourse-assign
          - rm -rf discourse-login-with-amazon
          - rm -rf discourse-lti
          - rm -rf discourse-microsoft-auth
          - rm -rf discourse-patreon
          - rm -rf discourse-subscriptions
          - rm -rf discourse-zendesk-plugin

(Tune as desired)

2 Likes