Botón con marca de verificación debe estar oculto para usuarios que no pueden desmarcar respuestas correctas

Hola al equipo de Discourse-solved,

Sugiero cambios en la experiencia de usuario: el botón con la marca de verificación debe ocultarse a los usuarios que no pueden desmarcar respuestas correctas.

02%20AM

La palabra SOLUCIÓN debe ser la única visible.

Gracias.

1 me gusta

I disagree - I think the filled box is an important part of the styling highlighting the post.

13 Me gusta

@riking

Having a checkbox tells users that I can uncheck it. If I am not the OP or admin, I shouldn’t see the checkbox. Only OP or admin should see checkbox because that action is only for them.

For everyone else, they should only see the word “SOLUTION”.

We can add additional highlights by making the background of the post ‘Green’ or have additional highlights around it. But not using the checkbox.

UX wise, having a checkbox for the readers is not the proper way.

To the discourse-solved developers, i’m not a ruby dev, but how can i modify this in code in case I want to remove the checkbox in my site for readers not OP/Admin? What part of the code handles this?

Thank you. :slight_smile:

1 me gusta

You can hide it by adding the following line of CSS to your theme:

.actions button.accepted {display:none;}

PS: this does show there’s a slight alignment issue with the ‘Solution’ text:

image

4 Me gusta

Thanks @bartv for the suggestion.

But the problem with that solution is it also hides the checkmark to OP or admin who should have the ability to uncheck it.

Ah true. Perhaps you could dig into the CSS a bit more to make the selector more specific and avoid this.

I was trying to do that and realize that this isn’t possible because you can’t add any conditions (if/else) in the CSS. The only way to make it work is editing it directly thru the plugin code.

To everyone that helped, thanks.

I was able to modify the plugin code already:

Here’s what I did:

For OP:
Instead of just the checkmark, I added this button - “This solved my question” which is more visible to the OP or readers.
24%20AM

Also, if OP wants to change his/her answer, this is what he/she sees:

42%20AM

Now, if I am not OP or admin. Here is what I see:

57%20AM

Again, thanks for those who have created this plugin. :slight_smile:

8 Me gusta

I actually like this change quite a bit @sam – makes it much clearer, if you want to prioritize solved in a category.

3 Me gusta

Maybe @awesomerobot can do some mockups here, I am fine to make solved clearer. I agree that marking something as a solution is not super clear to the OP.

5 Me gusta

Having "this solved my question below a series of short replies is going to get very noisy very quickly though.

Really need to show mockups of how a topic will look, rather than individual posts.

6 Me gusta

It’s noisy, but just for OP, so I don’t think it’s so bad. It’s worth a little noise if increases feature use.

I shortened the copy from “this solved my question” to “mark as solution,” the longer version is clearer, but it’s also… long. Using “mark” also gives us “unmark” as the reverse.

Also Font Awesome’s times-square (:negative_squared_cross_mark:) icon is premium-only, and the times-circle is free, so that’s why I’m using circles here.

Mobile’s a little tricky, maybe we show “solution” and then if they expand the controls we hide the text and just show the icon?

6 Me gusta

Interesting yeah maybe in mobile we suppress text till clicked … on that note, how would “unmarking” the solution work in mobile?

2 Me gusta

Yeah it’s difficult to keep the same amount of clarity on mobile, the post controls are already crammed. One option could be to move the controls for solved outside of the existing topic nav

5 Me gusta

How about emphasizing the mark as solution for the current reply only and shift the emphasis as the reader scrolls? Appreciate it’s much more involved but would reduce noise considerably.

2 Me gusta

It was implemented in:

https://github.com/discourse/discourse-solved/pull/78

This is how it looks on desktop:

Can accept / unaccept:


Cannot accept / unaccept:


The same, but for mobile:


7 Me gusta

Mi primera impresión es que esto lo ha hecho muy ruidoso.

El hecho de que la etiqueta sea tan larga “Marcar como solución” y esté más cerca del botón de me gusta que de la marca de verificación (por 2 píxeles :stuck_out_tongue:) tampoco ayuda mucho.

4 Me gusta

Siento que esto demuestra bastante bien mi preocupación anterior.

2 Me gusta

¿Y si aprovechamos el diseño de la Wiki para mantener un patrón?

Publicación normal:

Wiki:

Solución:
image

5 Me gusta

Creo que vale la pena reconsiderar la idea de cambiar la iconografía con este gran cambio. Los círculos parecen algo menos prominentes en la lista. Sé que hay cierto rechazo a lo que se podría considerar un “movimiento de jugada barata”. Sin embargo, me gustaría mantener los cuadrados si es posible con el cambio, incluso si tenemos que redibujar 1 o 2 SVG.

Intentamos la fusión el viernes, pero la revertí porque tuvimos un descuido y aplicamos los cambios de estilo a no OP. Esto estaba destinado a ser un cambio extremadamente acotado solo a OP (no al personal, por ejemplo).

Otra preocupación que tengo para OP es la “invitación continua” a “desmarcar como solución” una vez que algo ha sido marcado como solución; encuentro que es algo desordenado. ¿Hay algo que podamos hacer al respecto? Para “quitar el corazón”, simplemente haces clic en el corazón de nuevo, ¿por qué no seguimos el mismo patrón?

4 Me gusta