pfaffman
(Jay Pfaffman)
26 Ottobre 2021, 2:35pm
1
EDIT: I’m reclassifying this as a bug, so that someone who understands this better than I can take a look at it.
a bunch of uploads had “unknown” as the extension. This means that it’s impossible to generate thumbnails. I think this happened when moving a backup to a new site and then needed to regenerate the thumbnails.
I think what should happen when you try to generate thumbnails and the extension is ‘unknown’ is to replace the extension, something like
upload.extension = upload.original_filename.split('.').last
It seems like if this were done somewhere that I’d not have spent 4 hours on this.
Wait. This looks like the problem. Why return false rather than get the extension from the filename?
opts = opts.merge(raise_on_error: false)
if fix_image_extension
OptimizedImage.create_for(self, width, height, opts)
else
nil
end
end
end
def fix_image_extension
return false if extension == "unknown"
begin
# this is relatively cheap once cached
original_path = Discourse.store.path_for(self)
if original_path.blank?
external_copy = Discourse.store.download(self) rescue nil
original_path = external_copy.try(:path)
end
image_info = FastImage.new(original_path) rescue nil
Gory details follow.
I moved a site from /community to community.example.com by doing a backup and restore. I fixed the uploads with a
RAILS_ENV=production bundle exec script/discourse remap '/community/uploads' '/uploads'
But the avatars are still the Gray Man.
When I look at user.user_avatar.custom_upload.url and paste that URL into the browser, I get the desired avatar. It seems like I need to “rebake” the users.
I thought that perhaps a
rake avatars:refresh
or
rake avatars:clean
might fix it, but no joy.
What am I missing?
1 Mi Piace
IAmGav
(Gavin Perch)
26 Ottobre 2021, 2:41pm
2
In sidekiq there is a trigger to create missing avatars.
It takes a while, but that should help if I am not mistaken
2 Mi Piace
pfaffman
(Jay Pfaffman)
26 Ottobre 2021, 2:49pm
3
Good one! That callls User.refresh_avatar, but sadly
user=User.find_by_username('broken_avatar_guy')
user.refresh_avatar
also isn’t solving this.
2 Mi Piace
pfaffman
(Jay Pfaffman)
27 Ottobre 2021, 12:30pm
4
Here’s a clue:
ActionController::RoutingError (No route matches [GET] "/user_avatar/community.example.com/broken_user")
1 Mi Piace
IAmGav
(Gavin Perch)
27 Ottobre 2021, 12:51pm
5
Do it update when the user logs into their account ?
pfaffman
(Jay Pfaffman)
27 Ottobre 2021, 12:54pm
6
I don’t believe so.
user.user_avatar.custom_upload has the correct URL, but https://community.example.com/user_avatar/community.example.com/bad_user/25/321_2.png has the missing avatgar image. I need to find the way to rebuild those avatar thumbnails.
IAmGav
(Gavin Perch)
27 Ottobre 2021, 12:56pm
7
there is a force_avatar_update in the user login that i saw in the code.
IAmGav
(Gavin Perch)
27 Ottobre 2021, 1:01pm
8
this could be very helpful, it looks like a job
# frozen_string_literal: true
require 'rails_helper'
RSpec.describe Jobs::FixOutOfSyncUserUploadedAvatar do
it 'should fix out of sync user uploaded avatars' do
user_with_custom_upload = Fabricate(:user)
custom_upload1 = Fabricate(:upload, user: user_with_custom_upload)
gravatar_upload1 = Fabricate(:upload, user: user_with_custom_upload)
user_with_custom_upload.update!(uploaded_avatar: custom_upload1)
user_with_custom_upload.user_avatar.update!(
custom_upload: custom_upload1,
gravatar_upload: gravatar_upload1
)
user_out_of_sync = Fabricate(:user)
custom_upload2 = Fabricate(:upload, user: user_out_of_sync)
gravatar_upload2 = Fabricate(:upload, user: user_out_of_sync)
prev_gravatar_upload = Fabricate(:upload, user: user_out_of_sync)
This file has been truncated. show original
pfaffman
(Jay Pfaffman)
27 Ottobre 2021, 6:25pm
9
Something must be wrong:
user=User.find_by_username('Tuomo')
upload_id=user.user_avatar.custom_upload.id
upload = Upload.find(upload_id)
Discourse.avatar_sizes.each do |size|
OptimizedImage.create_for(upload, size, size)
end
OptimizedImage.where(upload_id: upload_id)
ANd I get the no opimized images.
broken_uploads = Upload.where(extension: "unknown")
broken_uploads.each do |upload|
upload.extension = upload.original_filename.split('.').last
upload.save
end
fixes that.
Then I just need to generate new thumbnails, like this:
has_upload = UserAvatar.where("custom_upload_id > 0")
has_upload.each do |user_avatar|
Jobs.enqueue(:create_avatar_thumbnails,{upload_id: user_avatar.custom_upload_id})
end
2 Mi Piace
pfaffman
(Jay Pfaffman)
10 Novembre 2021, 8:00pm
10
Penso che questo sia un bug legittimo e Jeff ed, ma non ha ricevuto ulteriore attenzione.
Sono pazzo o c’è qualcosa che non va qui?
2 Mi Piace
Ho spostato un sito da /community a community.example.com eseguendo un backup e ripristino
Immagino che non ci siamo mai imbattuti in questo con nessuno dei nostri ripristini, perché ciò di cui ti lamenti qui sono artefatti del ripristino, giusto? Forse specifici di questo backup e ripristino?
1 Mi Piace