As part of our brand, we are heavily redesigning a development install of Discourse ready for when we migrate over our existing forums.
During development and testing, I have picked up on a few cases where the forum temporarily reverts to the default (white) theme.
Steps to Reproduce
Whilst the Default theme has been disabled and a custom theme has been set…
- Sign up
- Await confirmation email - click link in email
- Navigate to /u/activate-account/
- “Click here to activate your acccount”
After clicking to activate your account, the subsequent “you have activated your account” page displays the default white theme until you click through or are re-directed to the forum index.
A similar behavior is also exhibited when I go to assign a new administrator and click on the verification link that is sent via email - on completion, a white page is shown, as below:
The latter isn’t a huge issue, as Administrators will be the only people to see this page, but it probably shouldn’t be happening when regular users go to verify their accounts.
Hopefully I’m just being silly and I’ve missed some small detail, but just in case I’m not being silly, I figured I would raise it here.
Sure, agreed, for the user-facing one, we should look at that @techAPJ.
I think this is not a trivial change as those pages are not using the Ember layout. Will discuss with Sam regarding this.
Themes are already working on static pages (with
Default Dark theme:
Discourse Vincent theme:
Maybe this is an edge case with per user theme? I doubt it, but worth double checking. (keep in mind the OP here is already logged on)
Works as expected when logged in with dark theme enabled in my preferences (default for everyone else) and accessing static page (
I can confirm on our dev site that the styling is now being correctly applied when doing things such as promoting administrators etc.
I did find one minor area that still has an issue. Try enabling the dark theme here on Meta and going to a page not found url like so:
The logo doesn’t seem to respect the styling:
I see the email verification page is using the dark theme as set, but after clicking activate account we are directed to another light page for a few seconds:
Before being redirected back to the home page (dark). Can we do anything about this interim light page?
I think everything in this topic has been addressed at this point. I ran through a normal sign-up flow and an approval-based sign-up flow and all of the pages appear to respect the current theme. I just pushed a solution for the inconsistent logo on static pages as well:
I’m going to go ahead and close this for now. If there are any new issues that come up. Please open a new topic!