Change of date in digest email body


(Neil) #1

Continuing the discussion from Date in digest emails are not localised:

There is still a date localisation problem in the actual digest message body where at the start of the digest it says "A brief summary of “[%{site_name}] since your last visit on mm-dd-year”.

This date format can be very confusing for our members who are mainly based in the UK.

If it could be localised or alternatively a full textual representation of the month used it would be appreciated.


(Gerhard Schlager) #2

That date is currently not translatable in Transifex. I submitted a fix for it some time ago…

https://github.com/discourse/discourse/pull/3787


(Jeff Atwood) #3

I think there were problems with that commit as I recall, which is why it hasn’t been merged.

@techapj can we change the digest default text so it uses a more universal date format? Maybe something like

Since your last visit on August 23rd

where the year is optional if it was in the current calendar yar.


(Gerhard Schlager) #4

Well, the date format should take the user’s locale into account, anything else is just a hack.

My PR worked perfectly fine in my dev environment. I haven’t been told about any problems, but if there are some, I’ll try to fix them.


(Arpit Jalan) #5

Done via:

https://github.com/discourse/discourse/commit/734c272de81baac8a70801e257a994a8a6e9f616


Will switch to localized date again once @gerhard’s PR is merged.


(Robin Ward) #6

I’ve merged in the PR from @gerhard now!


(Neil) #7

A huge thank you for making this change. It is a great improvement! …on this occasion the like button just didn’t seem enough!


(Neil) #8

This seems to have reverted back. I’m once again getting digests which are saying: A brief summary of XXXXXX Forum since your last visit on mm-dd-yyyy

Seems like it happened during an update between the 26th of December and the 2nd of January.


(Jeff Atwood) #9

Hmm I think you are right, @techapj can you check into this please?


(Arpit Jalan) #10

Okay, I made the date (with year) in digest email universal

(and localized, thanks @gerhard!)


(Régis Hanol) #11