Mischief
(Neil)
October 27, 2015, 8:09pm
1
Continuing the discussion from Date in digest emails are not localised :
This is one of those cases where I think the existence of the question implies deeper problems.
Omit Needless Words, right? So I am changing it to:
subject_template: "[%{site_name}] Digest"
Simpler, and no more date localization problem…
There is still a date localisation problem in the actual digest message body where at the start of the digest it says "A brief summary of “[%{site_name}] since your last visit on mm-dd-year”.
This date format can be very confusing for our members who are mainly based in the UK.
If it could be localised or alternatively a full textual representation of the month used it would be appreciated.
1 Like
gerhard
(Gerhard Schlager)
October 27, 2015, 11:11pm
2
That date is currently not translatable in Transifex. I submitted a fix for it some time ago…
https://github.com/discourse/discourse/pull/3787
3 Likes
I think there were problems with that commit as I recall, which is why it hasn’t been merged.
@techapj can we change the digest default text so it uses a more universal date format? Maybe something like
Since your last visit on August 23rd
where the year is optional if it was in the current calendar yar.
1 Like
gerhard
(Gerhard Schlager)
October 27, 2015, 11:19pm
4
Well, the date format should take the user’s locale into account, anything else is just a hack.
My PR worked perfectly fine in my dev environment. I haven’t been told about any problems, but if there are some, I’ll try to fix them.
3 Likes
techAPJ
(Arpit Jalan)
October 28, 2015, 4:50pm
5
4 Likes
eviltrout
(Robin Ward)
November 2, 2015, 6:40pm
6
I’ve merged in the PR from @gerhard now!
3 Likes
Mischief
(Neil)
November 16, 2015, 12:37pm
7
A huge thank you for making this change. It is a great improvement! …on this occasion the like button just didn’t seem enough!
4 Likes
Mischief
(Neil)
January 20, 2016, 8:00am
8
This seems to have reverted back. I’m once again getting digests which are saying: A brief summary of XXXXXX Forum since your last visit on mm-dd-yyyy
Seems like it happened during an update between the 26th of December and the 2nd of January.
2 Likes
Hmm I think you are right, @techapj can you check into this please?
3 Likes
techAPJ
(Arpit Jalan)
January 28, 2016, 5:57pm
10
4 Likes