Changing emoji set doesn't update old posts anymore

gerhard · Julho 24, 2016, 10:06pm

Continuing the discussion from Changing emoji set doesn't rebuild HTML:

There seems to be a regression. I don’t see a “Fix Emoji Links” in the scheduler after changing the emoji set and the new Win10 set is definitely missing from the allowed values.

codinghorror · Julho 25, 2016, 5:08am

Not sure, @eviltrout can have a look.

eviltrout · Julho 25, 2016, 4:12pm

You must be looking at a tree that doesn’t include the full update for win10 emoji somehow? You can see the site setting is indeed here:

github.com/discourse/discourse

app/models/emoji_set_site_setting.rb

master


      
          # frozen_string_literal: true
          
          require "enum_site_setting"
          
          class EmojiSetSiteSetting < EnumSiteSetting
            def self.valid_value?(val)
              values.any? { |v| v[:value] == val.to_s }
            end
          
            def self.values
              @values ||= [
                { name: "emoji_set.apple_international", value: "apple" },
                { name: "emoji_set.facebook_messenger", value: "facebook_messenger" },
                { name: "emoji_set.fluentui", value: "fluentui" },
                { name: "emoji_set.google", value: "google" },
                { name: "emoji_set.google_classic", value: "google_classic" },
                { name: "emoji_set.noto", value: "noto" },
                { name: "emoji_set.openmoji", value: "openmoji" },
                { name: "emoji_set.twemoji", value: "twemoji" },
                { name: "emoji_set.twitter", value: "twitter" },
                { name: "emoji_set.standard", value: "unicode" },
                { name: "emoji_set.win10", value: "win10" },
              ]
            end
          
            def self.translate_names?
              true
            end
          end

However there was a bug wit the job not being queued. I’ve fixed it below:

Thanks for letting me know

Tópico		Respostas	Visualizações
Changing emoji set doesn't rebuild HTML Bug	2	1003	7 de Janeiro de 2015
Some Emoji show broken Bug	6	1535	20 de Fevereiro de 2017
12 Broken Emoji per set Bug	8	1591	3 de Março de 2017
Emojis update Announcements emoji	58	1788	30 de Novembro de 2025
Win10 keycap_star.png emoji still broken Bug	3	1013	17 de Outubro de 2017

Changing emoji set doesn't update old posts anymore

Tópicos relacionados