Chat settings Saved text not translatable

Don · November 5, 2022, 11:08am

Hello,

I noticed the Saved texts not translatable on chat settings page.

discourse/discourse/blob/main/plugins/chat/assets/javascripts/discourse/templates/components/chat-channel-settings-view.hbs

<div class="chat-form__section">
  <div class="chat-form__field">
    <label class="chat-form__label">
      <span>{{i18n "chat.settings.mute"}}</span>
    </label>
    <div class="chat-form__control">
      <ComboBox @content={{this.mutedOptions}} @value={{this.channel.current_user_membership.muted}} @valueProperty="value" @class="channel-settings-view__muted-selector" @onChange={{action (fn this.saveNotificationSettings "muted")}} />
      {{#if this.savedMuted}}
        <span class="channel-settings-view__saved">✓ Saved</span>
      {{/if}}
    </div>
  </div>

  {{#unless this.channel.current_user_membership.muted}}
    <div class="chat-form__field">
      <label class="chat-form__label">
        <span>{{i18n "chat.settings.desktop_notification_level"}}</span>
      </label>
      <div class="chat-form__control">
        <ComboBox @content={{this.notificationLevels}} @value={{this.channel.current_user_membership.desktop_notification_level}} @valueProperty="value" @class="channel-settings-view__desktop-notification-level-selector" @onChange={{action (fn this.saveNotificationSettings "desktop_notification_level")}} />

This file has been truncated. show original

Thanks

joffreyjaffeux · November 8, 2022, 11:16pm

Good catch thanks

Will be fixed by this PR:

joffreyjaffeux · November 10, 2022, 11:17pm

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Edit reason: "reverted to version" text not translatable ux translation	2	348	February 11, 2023
Chat channel metadata date not translatable ux chat	3	436	January 26, 2024
Some settings aren't saving support unsupported-install	11	744	July 27, 2023
Chat retention days issue ux chat	7	681	February 20, 2023
Translations lost after upgrade support	5	635	January 15, 2023

Chat settings Saved text not translatable

Related Topics