Clicking on a post in nice reply badges opens user card, not post

bug
1

Repro: visit Nice Reply badge on Discourse Meta click on a post. See my usercard, even though mouseover shows the correct post URL.

I think this might be a meta-only issue.

5 Likes
2

I can repro it on my test site too, so not just here unfortunately.

3 Likes
4

The same applies to the bug reporter badge here.

5

I think it may be all of the ones with a post linked in them.

4 Likes
6

the link in the code even works as expected. :thinking:

console_badge_link
console_badge_link1071×719 188 KB

I can also reproduce this on my dev instance. Any badge with a link.

It appears to be because the whole badge card is a link to the user card and it’s overriding the inner links (instead of just the user avatar being a card link).

badge_card
badge_card1328×334 153 KB

1 Like
7

Because the initial <a> includes the whole badge info:

image

Well, you can fix it by closing this <a> at line 17

But that’s no good if there is no avatar for some reason. I think the “right” place to put it is before the first set of plugin outlets, but those are inside of a <div>, so it’s not trivial enough for me to fix, which I was hoping to do for Hacktoberfest. :crying_cat_face:

2 Likes
11

Thanks for reporting it! I was trying to reduce link repetition for screen readers but needed to take a different approach because I overlooked these badge links. Will be fixed by

5 Likes
12

This topic was automatically closed after 25 hours. New replies are no longer allowed.