Close button misalignments on banners

This is a very minor issue and easy to fix on a forum, but just in case, I wanted to share with staff.

There is a small misalignment between the close button on the notification banner and the banner topic, as you can see in this example.

I fixed it with a setting to 10px on this css class, but maybe you’ll go another route

https://github.com/discourse/discourse/blob/902d0e1e3a61bc2d2d05c617a6e8e51aaaf42b30/app/assets/stylesheets/common/base/alert.scss#L11

Like I said, it’s a very minor issue :grimacing:

2 Likes

ooo yeah that’s a good one cc @awesomerobot

3 Likes

I made some updates to improve this:

https://github.com/discourse/discourse/commit/1840023c284e05f8d5dad609528fc080ea228c3f

Screen Shot 2020-05-07 at 10.59.18 PM

5 Likes

This topic was automatically closed after 43 hours. New replies are no longer allowed.