Probably a bug relative to the close button on banner topic

Bug
1

Continuing the discussion from The close button was displayed on the left side, how to return it to the right?:

I have upgraded my test site (only plugins and no site customization) 3 or 4 days ago and I see that I have the close button (for login, sign up and banner) on the left.

I’ve seen it on many forums:

The difference that I can see with my live site (Discourse 1.8.0.beta10 - https://github.com/discourse/discourse version f968b4e6629c352e9f5425e35f5dcbe72f4fbe88) - where the close button is display in the correct position - is relative to the class .modal-close (the parent of .close I think) where is the float:right statement.

This is my forum:

1033×333 27.2 KB

This is https://discuss.moe/
https://i.imgur.com/pCCRLMb.png

For example, looking to http://foodtalkcentral.com/ and https://forum.fractalfuture.net/ I can see the correct position (on the right) when I try to login or signup. There is the class .modal-close and the float: right, but the close button for banners is on the left.

:rolling_eyes: :thinking:

3 Likes
2

I think others that also reported this tied it back to a specific plugin. What plugins do you have installed/enabled?

Doesn’t happen on my sandbox or try.discourse.org which are both on latest.

Might be related to Guest Gate (Sign Up Popup Plugin)

2 Likes
3

631×551 7.71 KB

Those are all the plugins in the live site where the button is in the correct position.

In the site test I have all those plugins (but some are disabled as patreon and probably some other)
The only plugin enabled (by another admin to test it) that I don’t use in my live forum is relative to Steam login.
The server we use for the test site is off now, so I can try to disable it tomorrow morning. BTW this Steam plugin was enabled for some weeks without problems.
The only difference is that I asked to my sys-team to upgrade the site test and delete the old backup relative to my live forum because I need to work on it with the plugins and without all the other data (discussions, users, site customization etc…)

EDIT : I opened https://discuss.moe/?safe_mode=no_custom%2Cno_plugins%2Conly_official and Fractal Future Forum – Envisioning and creating a better future in safe-mode but the close button is still on the left.

I don’t use this plugin

4

Oh, I see. I’ve updated your topic title. I completely missed the banner topic, as the second screenshot for https://discuss.moe/ is showing their login-modal as part of the guest gate plugin (and yes, their site is using guest-gate). That isn’t the topic banner.

I can 100% reproduce this using a topic banner and only in that spot when on latest.

Steps to Reproduce:

  1. Navigate to any topic
  2. Make it a banner topic
  3. Close button is on the top left of the banner (even after a hard refresh)
4 Likes
5

The screens are relative to the login pop-up indeed, because is the only difference that I see.
So my live site is affected by this bug but I cannot see it because the banner is always the same topic that I edit from time to time.
Thanks @cpradio

6

PR
https://github.com/discourse/discourse/pull/4832

5 Likes